fix(datagrid): show full border when detail pane is open #449
Conversation
Thank you, 🤖 Clarity Release Bot |
The `display: block` was interfering with the flex styles that make the placeholder element below the rows take up the remaining vertical space. This cased the border between the rows and the detail pane not to extend past the rows. This fixes a regression that was introduced in 086f45b.
kevinbuhmann
force-pushed
the
kevin/datagrid-detail-border
branch
from
813f8d2
to
cc1efff
Compare
|
The issue with this solution will come when you have a very long text without spaces. Usually such text is very long uuid separated by dashes inside the first column. |
I'll double check, but that was one of my test cases. I think it worked the same as before. Except for the border fix, of course. |
|
@bbogdanov, this looks correct to me. The "arrow" on the row and the column filter button are still visible. Let me know if I missed something.
|
Especially in VMC there is a lot of push back about this from users not being able to see the entire data of the column. Maybe some if there is a way to set |
That's a separate issue because the current behavior it to cut off non-breaking text. |
|
🎉 This PR is included in version 13.11.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 15.0.0-beta.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
This fixes a regression that was introduced in #302.
PR Checklist
PR Type
Bugfix
What is the current behavior?
The border between the column and the detail pane does not extend to the placeholder element below the rows.
What is the new behavior?
The border between the column and the detail pane extends to the placeholder element below the rows.
Does this PR introduce a breaking change?
No.