Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datagrid): detail-pane overlaping the content in smaller container #302

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

bbogdanov
Copy link
Contributor

Signed-off-by: Bogdan Bogdanov bbogdanov@vmware.com

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: vmware-archive/clarity#6429

image

What is the new behavior?

The detail-pane doesn't overlap the content of the datagrid table anymore when datagrid is in a smaller container.

image

FYI: VMC uses this approach for mostly a month and clients seems to not have issues with it anymore.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2022

👋 @bbogdanov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

Signed-off-by: Bogdan Bogdanov <bbogdanov@vmware.com>
Copy link
Contributor

@Jinnie Jinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks for adding the change for the very long text without breaks that we talked about.
It might need rework if we enable more than one column to be visible in future, but for now this is good enough to me.

@Jinnie Jinnie merged commit 086f45b into vmware-clarity:main Sep 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

🎉 This PR is included in version 13.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants