Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(datagrid): add expanded row visual tests #1293

Merged
merged 5 commits into from
Feb 28, 2024
Merged

chore(datagrid): add expanded row visual tests #1293

merged 5 commits into from
Feb 28, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

No visual regression tests for datagrid expandable rows.

Issue Number: CDE-1692

What is the new behavior?

Visual regression tests for datagrid expandable rows are added.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Follow up on #1288

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@github-actions GitHub Actions
Copy link
Contributor

This PR introduces visual changes: ba92bf6
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout expanded-row-tooltip-visual-tests_CDE-1692
git fetch https://github.com/vmware-clarity/ng-clarity.git ba92bf6732e5c6ae91f056ee245816d39f1c9c8b
git cherry-pick ba92bf6732e5c6ae91f056ee245816d39f1c9c8b
git push

@github-actions GitHub Actions
Copy link
Contributor

This PR introduces visual changes: f253441
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout expanded-row-tooltip-visual-tests_CDE-1692
git fetch https://github.com/vmware-clarity/ng-clarity.git f25344155aedb860a06c417ef26dcc9d21d81bca
git cherry-pick f25344155aedb860a06c417ef26dcc9d21d81bca
git push

@valentin-mladenov valentin-mladenov marked this pull request as ready for review February 28, 2024 14:26
@valentin-mladenov valentin-mladenov requested a review from a team February 28, 2024 14:26
@valentin-mladenov valentin-mladenov merged commit 6d4ea1a into main Feb 28, 2024
7 checks passed
@valentin-mladenov valentin-mladenov deleted the expanded-row-tooltip-visual-tests_CDE-1692 branch February 28, 2024 15:00
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
@valentin-mladenov @github-actions
chore(datagrid): add expanded row visual tests (#1293)
0ae6991 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [x] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
No visual regression tests for datagrid expandable rows.

Issue Number: CDE-1692

## What is the new behavior?
Visual regression tests for datagrid expandable rows are added.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
Follow up on #1288

---------

Co-authored-by: GitHub <noreply@github.com>
(cherry picked from commit 6d4ea1a)
@github-actions github-actions bot mentioned this pull request Feb 28, 2024
Merged
13 tasks
github-actions bot pushed a commit that referenced this pull request Feb 28, 2024
@valentin-mladenov @github-actions
chore(datagrid): add expanded row visual tests (#1293)
4a16798 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [x] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
No visual regression tests for datagrid expandable rows.

Issue Number: CDE-1692

## What is the new behavior?
Visual regression tests for datagrid expandable rows are added.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
Follow up on #1288

---------

Co-authored-by: GitHub <noreply@github.com>
(cherry picked from commit 6d4ea1a)
@github-actions github-actions bot mentioned this pull request Feb 28, 2024
Merged
13 tasks
valentin-mladenov added a commit that referenced this pull request Feb 29, 2024
@github-actions @valentin-mladenov @web-flow
chore(datagrid): add expanded row visual tests (backport to 16.x) (#1295
e2321fc 
)

Backport 6d4ea1a from #1293. 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [x] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
No visual regression tests for datagrid expandable rows.

Issue Number: CDE-1692

## What is the new behavior?
Visual regression tests for datagrid expandable rows are added.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

## Other information
Follow up on #1288

---------

Co-authored-by: Valentin Mladenov <valentin.mladenov@broadcom.com>
Co-authored-by: GitHub <noreply@github.com>
valentin-mladenov added a commit that referenced this pull request Feb 29, 2024
@github-actions @valentin-mladenov @web-flow
chore(datagrid): add expanded row visual tests (backport to 15.x) (#1294
cb66305 
)

Backport 6d4ea1a from #1293. 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [x] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?
No visual regression tests for datagrid expandable rows.

Issue Number: CDE-1692

## What is the new behavior?
Visual regression tests for datagrid expandable rows are added.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

## Other information
Follow up on #1288

---------

Co-authored-by: Valentin Mladenov <valentin.mladenov@broadcom.com>
Co-authored-by: GitHub <noreply@github.com>
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevinbuhmann kevinbuhmann kevinbuhmann approved these changes

Assignees
No one assigned
Labels
auto-backport-to-15.x auto-backport-to-16.x cla-not-required type:chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@valentin-mladenov @kevinbuhmann @vmwclabot @web-flow