fix(vertical-nav): set min-height of nav icon #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dont fall back to Core's min-height value when not using css tokens
closes #138
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The base size in core changed in v6, when not using the core tokens. While the ng css has a height/width set, it did not have a min-height and min-width, which was resulting in larger than expected icons in the vertical nav
Issue Number: #138
What is the new behavior?
Sets a min-height and min-width on the nav-icon to properly size the icon. Core will be addressed separately
Does this PR introduce a breaking change?
Other information