Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vertical-nav): align icon and text of selected link with other links (v12 backport) #298

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

kevinbuhmann
Copy link
Member

closes #293

This is a backport of #294.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [N/A] Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

Issue Number: #293

What is the new behavior?

The icon and text does shift when a link is selected.

Does this PR introduce a breaking change?

No

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann merged commit 182790a into 12.x Aug 26, 2022
@kevinbuhmann kevinbuhmann deleted the kevin/v12-vertical-nav-select-shift branch August 26, 2022 16:01
@github-actions
Copy link
Contributor

🎉 This PR is included in version 12.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants