feat: add core advanced row selection demo #12
Conversation
steve-haar
force-pushed
the
topic/core-ars
branch
from
97ed3f2
to
09f914c
Compare
| > | ||
| <cds-grid-column type="action"> | ||
| <cds-checkbox (click)="stopPropagation($event)"> | ||
| <input (click)="selectAll()" type="checkbox" [checked]="data.entirePageSelected" aria-label="Select All" /> |
There was a problem hiding this comment.
should this have an indeterminate in there?
There was a problem hiding this comment.
I think we talked about this yesterday, but is this even something we should have here? It's certainly not scalable to fetch all of the remote data to track all the items as selected.
There was a problem hiding this comment.
This check-all behavior can't be turned off in the angular grid and the angular grid doesn't have an indeterminate state. I thought they should behave identically, so this will make the core grid behave just like the angular grid.
There was a problem hiding this comment.
I think there is benefit in showing slightly different behavior if there is something you can do in Core that you can't do in NG, but the checkbox is probably not important enough for that.
There was a problem hiding this comment.
I'll merge for now, but we can pretty easily add indeterminate behavior if we want.
| [attr.selected]="data.selectedMap![vm.id]" | ||
| > | ||
| <cds-grid-cell> | ||
| <cds-checkbox (click)="stopPropagation($event)"> |
There was a problem hiding this comment.
Yes, I'd love any insights you can give. If I use a regular input checkbox (not wrapped in a cds-checkbox), then everything works fine. When I use the cds-checkbox, I have to add this otherwise it won't work properly. Do you have any idea what's going on?
There was a problem hiding this comment.
I don't, I can take a look after it's merged in. Does it not work at all? Or is it flakey? I noticed some flakiness in the grid in the core storybook, that I hadn't investigated yet, but for the most part it worked fine in vanilla web components.
There was a problem hiding this comment.
I think it has something to do with the cds-checkbox and not the grid (just my guess). The behavior is consistent and the select-all doesn't work at all if I don't have the stopPropagation.
Signed-off-by: Ashley Ryan <asryan@vmware.com>
steve-haar
force-pushed
the
topic/core-ars
branch
from
09f914c
to
5c9f902
Compare
No description provided.