Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid-demo): add angular column dom performance demo #15

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Jul 20, 2022

This requires some application logic for tracking which columns are hidden, but it can be pretty minimal depending on how you structure your grid.

I can't seem to find a way to remove the clr-dg-cell elements from the DOM without breaking the grid column width logic in one way or another. Bu rendering the contents of the cell only if the column is shown is relatively straightforward.

@vmware-clarity vmware-clarity deleted a comment from vmwclabot Jul 20, 2022
@kevinbuhmann kevinbuhmann force-pushed the kevin/hidden-columns branch 2 times, most recently from bbcaaa5 to c7c8070 Compare July 21, 2022 00:03
@kevinbuhmann kevinbuhmann marked this pull request as ready for review July 21, 2022 00:05
@kevinbuhmann kevinbuhmann marked this pull request as draft July 21, 2022 00:31
Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
@kevinbuhmann kevinbuhmann marked this pull request as ready for review July 21, 2022 17:38
@kevinbuhmann kevinbuhmann marked this pull request as draft July 25, 2022 15:34
@kevinbuhmann kevinbuhmann marked this pull request as ready for review July 25, 2022 17:10
@kevinbuhmann kevinbuhmann merged commit 4790269 into main Jul 25, 2022
@kevinbuhmann kevinbuhmann deleted the kevin/hidden-columns branch July 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants