Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grid-demo): maintain keyboard navigation in virtual rows directive (and add rendered range event) #27

Merged
merged 3 commits into from
Jul 29, 2022
Merged

fix(grid-demo): maintain keyboard navigation in virtual rows directive (and add rendered range event) #27

merged 3 commits into from
Jul 29, 2022

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Jul 29, 2022 •
edited

issue #37

@kevinbuhmann kevinbuhmann self-assigned this Jul 29, 2022
@vmware-clarity vmware-clarity deleted a comment from vmwclabot Jul 29, 2022
@kevinbuhmann kevinbuhmann marked this pull request as draft July 29, 2022 17:56
@kevinbuhmann kevinbuhmann marked this pull request as ready for review July 29, 2022 19:04
@kevinbuhmann kevinbuhmann marked this pull request as draft July 29, 2022 19:05
@kevinbuhmann kevinbuhmann marked this pull request as ready for review July 29, 2022 19:13
@kevinbuhmann
chore(grid-demo): extract datagridElementRef property
334a504 
Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
@vmware-clarity vmware-clarity deleted a comment from vmwclabot Jul 29, 2022
@kevinbuhmann
chore(grid-demo): add rendered range event to virtual rows directive
2048884 
This event can be leveraged to lazy load rows.

Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
@kevinbuhmann
fix(grid-demo): maintain keyboard navigation in virtual rows directive
7774b80 
Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
@kevinbuhmann kevinbuhmann merged commit 34ceba0 into main Jul 29, 2022
@kevinbuhmann kevinbuhmann deleted the kevin/virtual-rows-keyboard branch July 29, 2022 19:17
@kevinbuhmann kevinbuhmann mentioned this pull request Aug 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve-haar steve-haar steve-haar approved these changes

@ashleyryan ashleyryan Awaiting requested review from ashleyryan

Assignees

@kevinbuhmann kevinbuhmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kevinbuhmann @steve-haar @ashleyryan @vmwclabot