fix(grid-demo): maintain active cell in virtual rows correctly #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a mistake I made when refactoring c682471. Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
We need to track the active cell by index so that the active cell is set correctly after row elements are recycled. closes #73 Signed-off-by: Kevin Buhmann <kbuhmann@vmware.com>
kevinbuhmann
force-pushed
the
kevin/virtual-rows-active-cell-index
branch
from
42718a3
to
add8d3c
Compare
steve-haar
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #73
We need to track the active cell by index so that the active cell is set correctly after row elements are recycled.