Show warning when there are no images to pull #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juamedgod
reviewed
Jan 18, 2024
The output of `dt wrap` and `dt images pull` shows the following message
when there are no images to pull:
```
✔ All images pulled successfully
```
Instead, we are going to show a warning when there are no images to pull:
```
⚠️ No images found in Images.lock
```
alemorcuq
force-pushed
the
no-images-pull-warning
branch
from
6979f3f
to
d8f7a7f
Compare
juamedgod
approved these changes
Jan 23, 2024
juamedgod
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Show warning when there are no images to pull
The output of `dt wrap` and `dt images pull` shows the following message
when there are no images to pull:
```
✔ All images pulled successfully
```
Instead, we are going to show a warning when there are no images to pull:
```
⚠️ No images found in Images.lock
```
* Add missing scenario
* Improve error flow
* Don't try to pull images if there are no images to pull
juamedgod
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Show warning when there are no images to pull
The output of `dt wrap` and `dt images pull` shows the following message
when there are no images to pull:
```
✔ All images pulled successfully
```
Instead, we are going to show a warning when there are no images to pull:
```
⚠️ No images found in Images.lock
```
* Add missing scenario
* Improve error flow
* Don't try to pull images if there are no images to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
dt wrapanddt images pullshows the following message when there are no images to pull:Instead, we are going to show a warning when there are no images to pull: