-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GetTransaction for unit-testing transaction based context #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 70.27% 70.27%
=======================================
Files 13 13
Lines 1497 1497
=======================================
Hits 1052 1052
Misses 350 350
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. |
krishnamiriyala
force-pushed
the
support-delete-in-transaction
branch
2 times, most recently
from
September 19, 2023 20:18
6d33919
to
739ef44
Compare
YanhaoLi07
reviewed
Sep 19, 2023
krishnamiriyala
force-pushed
the
support-delete-in-transaction
branch
4 times, most recently
from
September 19, 2023 21:47
388e890
to
e06000c
Compare
krishnamiriyala
force-pushed
the
support-delete-in-transaction
branch
from
September 19, 2023 21:48
e06000c
to
87b731b
Compare
@krishnamiriyala Please modify the MR description, this is a test case fix. cc @YanhaoLi07 |
krishnamiriyala
changed the title
Make GetDBTransaction shareable across multiple finisher methods
Use GetTransaction for unit-testing transacation based context
Sep 19, 2023
krishnamiriyala
changed the title
Use GetTransaction for unit-testing transacation based context
Use GetTransaction for unit-testing transaction based context
Sep 19, 2023
Done |
jeyhun
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49