Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GetTransaction for unit-testing transaction based context #62

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

krishnamiriyala
Copy link
Contributor

@krishnamiriyala krishnamiriyala commented Sep 19, 2023

Fixes #49

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #62 (87b731b) into main (34094f9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   70.27%   70.27%           
=======================================
  Files          13       13           
  Lines        1497     1497           
=======================================
  Hits         1052     1052           
  Misses        350      350           
  Partials       95       95           
Flag Coverage Δ
unit-tests 70.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@krishnamiriyala krishnamiriyala force-pushed the support-delete-in-transaction branch 2 times, most recently from 6d33919 to 739ef44 Compare September 19, 2023 20:18
pkg/datastore/datastore_with_txcontext_test.go Outdated Show resolved Hide resolved
pkg/datastore/datastore_with_txcontext_test.go Outdated Show resolved Hide resolved
pkg/datastore/datastore_with_txcontext_test.go Outdated Show resolved Hide resolved
pkg/datastore/datastore_with_txcontext_test.go Outdated Show resolved Hide resolved
pkg/datastore/datastore_with_txcontext_test.go Outdated Show resolved Hide resolved
pkg/datastore/datastore_with_txcontext_test.go Outdated Show resolved Hide resolved
@krishnamiriyala krishnamiriyala force-pushed the support-delete-in-transaction branch 4 times, most recently from 388e890 to e06000c Compare September 19, 2023 21:47
@gaurav-vmware
Copy link
Contributor

@krishnamiriyala Please modify the MR description, this is a test case fix.

cc @YanhaoLi07

@krishnamiriyala krishnamiriyala changed the title Make GetDBTransaction shareable across multiple finisher methods Use GetTransaction for unit-testing transacation based context Sep 19, 2023
@krishnamiriyala krishnamiriyala changed the title Use GetTransaction for unit-testing transacation based context Use GetTransaction for unit-testing transaction based context Sep 19, 2023
@krishnamiriyala
Copy link
Contributor Author

@krishnamiriyala Please modify the MR description, this is a test case fix.

cc @YanhaoLi07

Done

@krishnamiriyala krishnamiriyala merged commit c71d6bc into main Sep 19, 2023
6 checks passed
@krishnamiriyala krishnamiriyala deleted the support-delete-in-transaction branch September 19, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose external transaction support for datastore methods
6 participants