warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
   --> lib/node-replication/cnr/src/lib.rs:166:5
    |
166 |     fn dispatch<'a>(&self, op: Self::ReadOperation<'a>) -> Self::Response;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: the loop variable `logidx` is used to index `tails`
    --> lib/node-replication/cnr/src/replica.rs:1076:23
     |
1076 |         for logidx in start..end {
     |                       ^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
     |
1076 |         for (logidx, <item>) in tails.iter().enumerate().take(end).skip(start) {
     |             ~~~~~~~~~~~~~~~~    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
    --> lib/node-replication/cnr/src/replica.rs:1074:73
     |
1074 |     fn is_replica_sync_for_logs(&self, start: usize, end: usize, tails: &Vec<usize>) -> bool {
     |                                                                         ^^^^^^^^^^^ help: change this to: `&[usize]`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

warning: unneeded `return` statement
    --> lib/node-replication/cnr/src/replica.rs:1084:9
     |
1084 |         return is_synced;
     |         ^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
     = help: remove `return`

warning: the loop variable `logidx` is used to index `depends_on`
    --> lib/node-replication/cnr/src/replica.rs:1042:31
     |
1042 |                 for logidx in 1..self.logstate.len() {
     |                               ^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
     |
1042 |                 for (logidx, <item>) in depends_on.iter().enumerate().take(self.logstate.len()).skip(1) {
     |                     ~~~~~~~~~~~~~~~~    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: unneeded `return` statement
    --> lib/node-replication/cnr/src/replica.rs:1059:30
     |
1059 |                     false => return false,
     |                              ^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
     = help: remove `return`

warning: unneeded `return` statement
    --> lib/node-replication/cnr/src/replica.rs:1057:25
     |
1057 |                         return true;
     |                         ^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
     = help: remove `return`

warning: unneeded `return` statement
    --> lib/node-replication/cnr/src/replica.rs:1035:25
     |
1035 |                         return self.is_replica_sync_for_logs(logidx, logidx + 1, depends_on);
     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
     = help: remove `return`

warning: unneeded `return` statement
    --> lib/node-replication/cnr/src/replica.rs:1032:29
     |
1032 |                     true => return true,
     |                             ^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
     = help: remove `return`

warning: unneeded `return` statement
    --> lib/node-replication/cnr/src/replica.rs:1001:25
     |
1001 |                         return self.handle_scan_op(o, thread_id, hashidx, rid, tid, depends_on);
     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
     = help: remove `return`

warning: unneeded `return` statement
   --> lib/node-replication/cnr/src/replica.rs:997:25
    |
997 |                         return true;
    |                         ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = help: remove `return`

warning: unneeded `return` statement
   --> lib/node-replication/cnr/src/replica.rs:970:25
    |
970 |                         return self.handle_scan_op(o, thread_id, hashidx, rid, tid, depends_on);
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = help: remove `return`

warning: unneeded `return` statement
   --> lib/node-replication/cnr/src/replica.rs:966:25
    |
966 |                         return true;
    |                         ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = help: remove `return`

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
   --> lib/node-replication/cnr/src/replica.rs:842:5
    |
842 | /     fn read_only<'rop>(
843 | |         &self,
844 | |         op: <D as Dispatch>::ReadOperation<'rop>,
845 | |         tid: usize,
846 | |     ) -> <D as Dispatch>::Response {
    | |__________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: called `unwrap` on `r` after checking its variant with `is_some`
   --> lib/node-replication/cnr/src/replica.rs:760:24
    |
759 |             if r.is_some() {
    |             -------------- help: try: `if let Some(..) = r`
760 |                 return r.unwrap();
    |                        ^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
   --> lib/node-replication/cnr/src/replica.rs:741:5
    |
741 | /     pub fn execute<'rop>(
742 | |         &self,
743 | |         op: <D as Dispatch>::ReadOperation<'rop>,
744 | |         idx: ReplicaToken,
745 | |     ) -> <D as Dispatch>::Response {
    | |__________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: unneeded `return` statement
   --> lib/node-replication/cnr/src/replica.rs:635:29
    |
635 | / ...                   return self
636 | | ...                       .handle_scan_op(o, thread_id, *logidx, rid, tid, depends_on);
    | |______________________________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = help: remove `return`

warning: unneeded `return` statement
   --> lib/node-replication/cnr/src/replica.rs:631:29
    |
631 | ...                   return true;
    |                       ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = help: remove `return`

warning: returning the result of a `let` binding from a block
   --> lib/node-replication/cnr/src/replica.rs:604:9
    |
602 |         let resp = self.get_response(idx.0, hash);
    |         ------------------------------------------ unnecessary `let` binding
603 |
604 |         resp
    |         ^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
    = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
    |
602 ~         
603 | 
604 ~         self.get_response(idx.0, hash)
    |

warning: redundant clone
   --> lib/node-replication/cnr/src/replica.rs:596:29
    |
596 |         self.make_pending(op.clone(), idx.0, hash, true);
    |                             ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> lib/node-replication/cnr/src/replica.rs:596:27
    |
596 |         self.make_pending(op.clone(), idx.0, hash, true);
    |                           ^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

warning: redundant clone
   --> lib/node-replication/cnr/src/replica.rs:498:29
    |
498 |         self.make_pending(op.clone(), idx.0, hash, false);
    |                             ^^^^^^^^ help: remove this
    |
note: this value is dropped without further use
   --> lib/node-replication/cnr/src/replica.rs:498:27
    |
498 |         self.make_pending(op.clone(), idx.0, hash, false);
    |                           ^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
    = note: `#[warn(clippy::redundant_clone)]` on by default

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
   --> lib/node-replication/cnr/src/replica.rs:274:5
    |
274 | /     pub fn with_data<'b>(
275 | |         logs: Vec<Arc<Log<'b, <D as Dispatch>::WriteOperation>>>,
276 | |         d: D,
277 | |     ) -> Arc<Replica<'b, D>> {
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
   --> lib/node-replication/cnr/src/replica.rs:254:5
    |
254 | /     pub fn new<'b>(
255 | |         logs: Vec<Arc<Log<'b, <D as Dispatch>::WriteOperation>>>,
256 | |     ) -> Arc<Replica<'b, D>> {
    | |____________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `#[warn(clippy::needless_lifetimes)]` on by default

warning: very complex type used. Consider factoring parts into `type` definitions
  --> lib/node-replication/cnr/src/replica.rs:90:18
   |
90 |     scan_buffer: CachePadded<RefCell<Vec<(<D as Dispatch>::WriteOperation, usize)>>>,
   |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: very complex type used. Consider factoring parts into `type` definitions
  --> lib/node-replication/cnr/src/replica.rs:87:13
   |
87 |     buffer: CachePadded<RefCell<Vec<(<D as Dispatch>::WriteOperation, usize)>>>,
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity