Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a race condition while initializing a ChildReconciler #227

Merged
merged 1 commit into from
May 5, 2022

Conversation

scothis
Copy link
Contributor

@scothis scothis commented May 5, 2022

This isn't a big deal as worst case we create an extra cache, but we can
easily avoid it.

Signed-off-by: Scott Andrews andrewssc@vmware.com

This isn't a big deal as worst case we create an extra cache, but we can
easily avoid it.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #227 (852f310) into main (c8e0a01) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   62.18%   62.22%   +0.04%     
==========================================
  Files           9        9              
  Lines         907      908       +1     
==========================================
+ Hits          564      565       +1     
  Misses        325      325              
  Partials       18       18              
Impacted Files Coverage Δ
reconcilers/reconcilers.go 80.06% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8e0a01...852f310. Read the comment docs.

@scothis scothis merged commit fe9dc70 into vmware-labs:main May 5, 2022
@scothis scothis deleted the once branch May 5, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants