Allow ResourceReconciler to skip status updates #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typically only a single controller should process a given resource. If multiple controllers are updating the status, they can fight over who controls the status. SkipStatusUpdate is a flag for ResourceReconciler that allows a reconciler to augment another controller without conflicting with the primary resource. This means that any errors or success state will not appear on the resource, this state will need to be communicated via other means, like logs and events. Finalizers may still be set, but requires the other controller(s) to be accommodating of foreign finalizers. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 58.08% 58.12% +0.04%
==========================================
Files 14 14
Lines 1954 1956 +2
==========================================
+ Hits 1135 1137 +2
Misses 741 741
Partials 78 78
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically only a single controller should process a given resource. If multiple controllers are updating the status, they can fight over who controls the status.
SkipStatusUpdate is a flag for ResourceReconciler that allows a reconciler to augment another controller without conflicting with the primary resource. This means that any errors or success state will not appear on the resource, this state will need to be communicated via other means, like logs and events.
Finalizers may still be set, but requires the other controller(s) to be accommodating of foreign finalizers.