Preserve results when subreconcilers halt #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A subreconciler may simultaneously want to halt the current reconciliation (by returning a HaltSubReconcilers error) and request a requeue (by returning a Result). When a call to a subreconciler fails, return the original Result object to the caller. Resolves: vmware-labs#389
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 59.52% 59.52%
=======================================
Files 16 16
Lines 2127 2127
=======================================
Hits 1266 1266
Misses 780 780
Partials 81 81
☔ View full report in Codecov by Sentry. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A subreconciler may simultaneously want to halt the current reconciliation (by returning a HaltSubReconcilers error) and request a requeue (by returning a Result). When a call to a subreconciler fails, return the original Result object to the caller.
Resolves: #389