Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concatenated log context in Sequence #412

Merged
merged 1 commit into from Aug 23, 2023

Conversation

cjnosal
Copy link
Contributor

@cjnosal cjnosal commented Aug 22, 2023

Each child reconciler was receiving the accumulated log context of all prior children in the Sequence

Before:

INFO MyResourceReconciler.0.MyChildSetReconciler.0.id $msg
INFO MyResourceReconciler.0.MyChildSetReconciler.0.1.id $msg
INFO MyResourceReconciler.0.MyChildSetReconciler.0.1.2.id $msg

After:

INFO MyResourceReconciler.0.MyChildSetReconciler.0.id $msg
INFO MyResourceReconciler.0.MyChildSetReconciler.1.id $msg
INFO MyResourceReconciler.0.MyChildSetReconciler.2.id $msg

Each child reconciler was receiving the accumulated log context of all
prior children in the Sequence
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0ced1f4) 60.62% compared to head (4768e6c) 60.62%.

❗ Current head 4768e6c differs from pull request most recent head fbed359. Consider uploading reports for the commit fbed359 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   60.62%   60.62%           
=======================================
  Files          24       24           
  Lines        2334     2334           
=======================================
  Hits         1415     1415           
  Misses        835      835           
  Partials       84       84           
Files Changed Coverage Δ
reconcilers/sequence.go 55.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scothis
Copy link
Contributor

scothis commented Aug 23, 2023

Good catch. Thanks

@scothis scothis merged commit 23ff219 into vmware-labs:main Aug 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants