Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid implying that the error can be anything but nil #417

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

squeedee
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (55557b2) 60.62% compared to head (d772a1c) 60.62%.

❗ Current head d772a1c differs from pull request most recent head 3e414b5. Consider uploading reports for the commit 3e414b5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   60.62%   60.62%           
=======================================
  Files          24       24           
  Lines        2334     2334           
=======================================
  Hits         1415     1415           
  Misses        835      835           
  Partials       84       84           
Files Changed Coverage Δ
reconcilers/child.go 83.82% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scothis scothis merged commit 5be8c31 into vmware-labs:main Aug 29, 2023
4 checks passed
@squeedee squeedee deleted the blocked-err branch August 29, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants