Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Dockerfile #187

Merged
merged 1 commit into from Jul 25, 2023
Merged

Conversation

dierbei
Copy link
Contributor

@dierbei dierbei commented Jul 25, 2023

I increased the ENTRYPOINT in the Dockerfile to default to the path to the wws executable.

And the CMD command can override the default value when running the image.

Fixes: #166

@vmwclabot
Copy link

@dierbei, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@dierbei, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link

@dierbei, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide a valid email address

@vmwclabot
Copy link

@dierbei, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

Copy link
Member

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @dierbei! A couple of comments before we can merge it :)

image/Dockerfile Outdated Show resolved Hide resolved
image/Dockerfile Show resolved Hide resolved
@vmwclabot
Copy link

@dierbei, VMware has approved your signed contributor license agreement.

Copy link
Member

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dierbei! 👏

@ereslibre ereslibre merged commit be9e355 into vmware-labs:main Jul 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify how you run wws commands in the container
3 participants