Skip to content

fix: update Dockerfile - #187

Merged
ereslibre merged 1 commit into
vmware-labs:mainfrom
dierbei:update-dockerfile
Jul 25, 2023
Merged

fix: update Dockerfile#187
ereslibre merged 1 commit into
vmware-labs:mainfrom
dierbei:update-dockerfile

Conversation

@dierbei

@dierbei dierbei commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

I increased the ENTRYPOINT in the Dockerfile to default to the path to the wws executable.

And the CMD command can override the default value when running the image.

Fixes: #166

@vmwclabot

Copy link
Copy Markdown

@dierbei, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot

Copy link
Copy Markdown

@dierbei, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot

Copy link
Copy Markdown

@dierbei, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Please provide a valid email address

@vmwclabot

Copy link
Copy Markdown

@dierbei, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@ereslibre ereslibre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @dierbei! A couple of comments before we can merge it :)

Comment thread image/Dockerfile Outdated
Comment thread image/Dockerfile
@vmwclabot

Copy link
Copy Markdown

@dierbei, VMware has approved your signed contributor license agreement.

@dierbei
dierbei force-pushed the update-dockerfile branch from 1d75970 to cc58188 Compare July 25, 2023 08:22

@ereslibre ereslibre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dierbei! 馃憦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify how you run wws commands in the container

3 participants