Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stderr path #203

Merged
merged 1 commit into from Aug 31, 2023
Merged

Conversation

ereslibre
Copy link
Member

Inherit stderr from the host, so that workers have the chance to log information through their stderr, that will end up in the host side (let it be the WWS binary itself running standalone, or through runwasi, for example).

@ereslibre ereslibre requested a review from a team August 31, 2023 07:58
Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've just added a minor comment before merging it 😄

crates/worker/src/lib.rs Outdated Show resolved Hide resolved
@ereslibre
Copy link
Member Author

Will merge on 🟢

Copy link
Contributor

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@ereslibre ereslibre merged commit c0cc415 into vmware-labs:main Aug 31, 2023
5 checks passed
@ereslibre ereslibre deleted the remove-stderr-path branch August 31, 2023 08:58
@Angelmmiguel Angelmmiguel added this to the v1.5.0 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants