Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add support for SLES 15 (SP3) machine image #227

Merged
merged 8 commits into from
Jul 22, 2022

Conversation

gcblack
Copy link
Contributor

@gcblack gcblack commented Jul 22, 2022

Summary of Pull Request

Adds support for SUSE Enterprise Linux 15 machine image.

  • 15.3 / SP3 for initial introduction

Known issues:

  • HTTP-based kickstart only.

Will note in the Release Notes and CHANGELOG.md

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Related to Existing Issues

Closes: #199

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bugfixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam changed the title Sle15 draft feat: Add support for SLES 15 (SP3) machine image Jul 22, 2022
@tenthirtyam tenthirtyam added this to the v22.07 milestone Jul 22, 2022
@tenthirtyam tenthirtyam changed the title feat: Add support for SLES 15 (SP3) machine image feat: Add support for SLE 15 (SP3) machine image Jul 22, 2022
Updates to `latest 15.3`.
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Great results in the initial tests. Will run a final set before merge! :octocat:

@tenthirtyam tenthirtyam changed the title feat: Add support for SLE 15 (SP3) machine image feat: Add support for SLES 15 (SP3) machine image Jul 22, 2022
@tenthirtyam tenthirtyam added priority/high High Priority sev/low Low labels Jul 22, 2022
Updates "SUSE Linux Enterprise 15" to "SUSE Linux Enterprise Server 15"
@tenthirtyam tenthirtyam changed the title feat: Add support for SLES 15 (SP3) machine image enhance: Add support for SLES 15 (SP3) machine image Jul 22, 2022
@tenthirtyam tenthirtyam added type/enhancement Enhancement and removed type/feature Feature labels Jul 22, 2022
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid testing!

:octocat: Merging!

@tenthirtyam tenthirtyam merged commit 0f34509 into vmware-samples:main Jul 22, 2022
tenthirtyam added a commit that referenced this pull request Jul 22, 2022
Adds SUSE Linux Enterprise Server 15. 

#227
@gcblack gcblack deleted the sle15-draft branch July 27, 2022 19:22
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for a SLES 15 machine image
2 participants