Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump windows 11 to 22h2 september 2022 #284

Merged
merged 4 commits into from
Sep 28, 2022

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Sep 21, 2022

Summary of Pull Request

Bumps Windows 11 to the 22H2 September 2022 release.

In addition, in Windows 11 22H2 the value for the OS image has changed from Windows 10 Pro to Windows 11 Pro.

        <ImageInstall>
            <OSImage>
               <InstallFrom>
                  <MetaData wcm:action="add">
                     <Key>/IMAGE/NAME</Key>
                     <Value>${vm_inst_os_image}</Value>
                  </MetaData>
               </InstallFrom>
               <InstallTo>
                  <DiskID>0</DiskID>
                  <PartitionID>4</PartitionID>
               </InstallTo>
            </OSImage>
         </ImageInstall>

Signed-off-by: Ryan Johnson johnsonryan@vmware.com

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Bumps Windows 11 to the 22H2 September 2022 release.

Signed-off-by: Ryan Johnson johnsonryan@vmware.com
@tenthirtyam tenthirtyam added this to the v22.09 milestone Sep 21, 2022
@tenthirtyam tenthirtyam self-assigned this Sep 21, 2022
@tenthirtyam tenthirtyam added the size/xs X-Small label Sep 21, 2022
@tenthirtyam tenthirtyam marked this pull request as draft September 21, 2022 22:06
@tenthirtyam
Copy link
Contributor Author

Blocked.

Update to 22H2 results in a WinRM issue:

==> vsphere-iso.windows-desktop: IP address: 172.16.14.110
==> vsphere-iso.windows-desktop: Using WinRM communicator to connect: 172.16.14.110
==> vsphere-iso.windows-desktop: Waiting for WinRM to become available...

@tenthirtyam tenthirtyam added the area/dependencies Area: Dependencies label Sep 27, 2022
@tenthirtyam
Copy link
Contributor Author

tenthirtyam commented Sep 27, 2022

Error: image

Solution: Recoding the windows-init.ps script.

Updates the `./scripts/windows/windows-init.ps1` to be more succinct work with Windows 11 22H2.

Tested with each Windows option in the project.

#284

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam marked this pull request as ready for review September 27, 2022 22:04
Updates the `./scripts/windows/windows-init.ps1` to be more succinct work with Windows 11 22H2.

Tested with each Windows option in the project.

#284

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Copy link
Contributor Author

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

`$profile`: PSAvoidAssignmentToAutomaticVariable

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam merged commit 10d1316 into main Sep 28, 2022
@tenthirtyam tenthirtyam deleted the chore/bump-windows-11 branch September 28, 2022 01:41
tenthirtyam added a commit that referenced this pull request Sep 28, 2022
Updates `CHANGELOG.md` to include dependency update provided in #284.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam added a commit that referenced this pull request Sep 28, 2022
Updates `CHANGELOG.md` to include dependency update provided in #284.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependencies Area: Dependencies priority/medium Priority Medium sev/low Low size/xs X-Small type/chore Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant