Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update custom role privileges #339

Merged
merged 1 commit into from
Nov 8, 2022
Merged

fix: update custom role privileges #339

merged 1 commit into from
Nov 8, 2022

Conversation

tenthirtyam
Copy link
Contributor

Summary of Pull Request

Adds missing privilege to README.md configuration section and the Terraform example for a custom vSphere role.

Virtual Machine > Configuration > Modify device settings = VirtualMachine.Config.EditDevice

Signed-off-by: Ryan Johnson johnsonryan@vmware.com

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #337

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam
fix: update custom role privileges
f2f6e63 
Adds missing privilege to `README.md` configuration section and the Terraform example for a custom vSphere role.

`Virtual Machine > Configuration > Modify device settings` = `VirtualMachine.Config.EditDevice`

#337

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam added type/bug Bug type/docs Documentation area/terraform Area: Terraform labels Nov 8, 2022
@tenthirtyam tenthirtyam added this to the v22.11 milestone Nov 8, 2022
@tenthirtyam tenthirtyam requested a review from a team as a code owner November 8, 2022 16:28
@tenthirtyam tenthirtyam self-assigned this Nov 8, 2022
@tenthirtyam tenthirtyam merged commit f176918 into main Nov 8, 2022
@tenthirtyam tenthirtyam mentioned this pull request Nov 8, 2022
Closed
10 tasks
@tenthirtyam tenthirtyam deleted the fix/update-custom-role-privileges branch November 8, 2022 17:32
tenthirtyam added a commit that referenced this pull request Nov 8, 2022
@tenthirtyam
docs: update CHANGELOG.md
b333b00 
Updates `CHANGELOG.md` to include fixes in GH-295, GH-339, and GH-340.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@tenthirtyam tenthirtyam

Labels
area/terraform Area: Terraform type/bug Bug type/docs Documentation
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Error: Permission to perform this operation was denied
1 participant
@tenthirtyam