refactor: Use Git branch / tag for versioning #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tenthirtyam Please let me know what you think about this code change and I will add the other operating systems / releases. |
tenthirtyam
changed the title
|
Hi @dhoppe 👋 Could you kindly open an enhancement request for this refactoring and link the pull request? Thanks! Ryan Johnson |
tenthirtyam
reviewed
Nov 29, 2022
There was a problem hiding this comment.
Initial testing from a git clone...
CONFIRM: Build a Ubuntu Server 22.04 LTS (cloud-init) Template for VMware vSphere?
Continue? (y/n)
y
Building a Ubuntu Server 22.04 LTS (cloud-init) Template for VMware vSphere...
Initializing HashiCorp Packer and required plugins...
Starting the build....
Error: Datasource.Execute failed: reference not found
on /Users/tenthirtyam/Downloads/packer-examples-for-vsphere-build_version/builds/linux/ubuntu/22-04-lts/linux-ubuntu.pkr.hcl line 26:
(source code not available)
Error: Unsupported attribute
on /Users/tenthirtyam/Downloads/packer-examples-for-vsphere-build_version/builds/linux/ubuntu/22-04-lts/linux-ubuntu.pkr.hcl line 41:
(source code not available)
This object does not have an attribute named "vm_name".
Error: Unsupported attribute
on /Users/tenthirtyam/Downloads/packer-examples-for-vsphere-build_version/builds/linux/ubuntu/22-04-lts/linux-ubuntu.pkr.hcl line 54:
(source code not available)
This object does not have an attribute named "build_version".
Error: Unsupported attribute
on /Users/tenthirtyam/Downloads/packer-examples-for-vsphere-build_version/builds/linux/ubuntu/22-04-lts/linux-ubuntu.pkr.hcl line 34:
(source code not available)
This object does not have an attribute named "git-repository".
Error: Unsupported attribute
on /Users/tenthirtyam/Downloads/packer-examples-for-vsphere-build_version/builds/linux/ubuntu/22-04-lts/linux-ubuntu.pkr.hcl line 35:
(source code not available)
This object does not have an attribute named "build_version".
dhoppe
force-pushed
the
build_version
branch
from
4685101
to
5b6195c
Compare
dhoppe
changed the title
|
@tenthirtyam Could you please check if the Git plugin has been installed? I do not have any issues, except the missing Ansible config related to OpenSSH 9.x. |
|
@dhoppe - yes, it's the second plugin shown below: ➜ packer plugins installed
/Users/tenthirtyam/.packer.d/plugins/github.com/rgl/windows-update/packer-plugin-windows-update_v0.14.1_x5.0_darwin_amd64
/Users/tenthirtyam/.packer.d/plugins/github.com/ethanmdavidson/git/packer-plugin-git_v0.3.2_x5.0_darwin_amd64
/Users/tenthirtyam/.packer.d/plugins/github.com/hashicorp/virtualbox/packer-plugin-virtualbox_v1.0.4_x5.0_darwin_amd64
/Users/tenthirtyam/.packer.d/plugins/github.com/hashicorp/vmware/packer-plugin-vmware_v1.0.7_x5.0_darwin_amd64
/Users/tenthirtyam/.packer.d/plugins/github.com/hashicorp/vsphere/packer-plugin-vsphere_v1.1.0_x5.0_darwin_amd64 |
|
The issue above was related to simply downloading the source and attempting to run as-provided. The Configuration section of the README.md will need to be updated to reflect the use of: Cloning from
|
tenthirtyam
previously requested changes
Nov 29, 2022
dhoppe
force-pushed
the
build_version
branch
from
9f700be
to
cc4c1f7
Compare
I just updated the documentation and found a logical error. I have only determined the last available tag, but not the one actually used. |
tenthirtyam
reviewed
Nov 29, 2022
tenthirtyam
reviewed
Nov 29, 2022
tenthirtyam
reviewed
Nov 29, 2022
dhoppe
force-pushed
the
build_version
branch
3 times, most recently
from
e09b0f8
to
1cae0ab
Compare
I actually noticed the same with testing with multiple tags - just let me know when you're all set. This is a very nice enhancement - thank you! |
dhoppe
force-pushed
the
build_version
branch
from
1cae0ab
to
ab4148a
Compare
I think this pull request is ready to be merged. I already fixed that issue because I do not need to fetch the tags. The data source PS: Time to go to bed. It is already late in Germany. ;) |
|
I'll review it tomorrow - thanks again for the enhancement suggestion! |
Updates `README.md`: - Adds link to `packer-plugin-git` as well as version used. - Updates the order for the Configuration section. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
dhoppe
commented
Nov 30, 2022
Updates `README.md` to remove duplicate warning in the configuration section. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
approved these changes
Nov 30, 2022
tenthirtyam
added a commit
that referenced
this pull request
Nov 30, 2022
Updates `CHANGELOG.md` to include enhancements included in #385. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
added a commit
that referenced
this pull request
Nov 30, 2022
Updates `CHANGELOG.md` to include enhancements included in #385. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
The build already has the timestamp as
build_date. Consider using the current Git branch / tag asbuild_version, so that it is clear on which code base the image was built.Type of Pull Request
type/bugtype/featureortype/enhancementtype/docstype/refactortype/chorePlease describe:
Related to Existing Issues
Closes #388
Test and Documentation Coverage
Breaking Changes?