feat: Allow SSH authentication with RSA keys #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyam
reviewed
Nov 29, 2022
tenthirtyam
changed the title
I need to do some testing. I think this is related to the OpenSSH version of the client. For example I have installed OpenSSH 9.1 at macOS, because I use a YubiKey for SSH via GPG. |
dhoppe
force-pushed
the
ansible_ssh_extra_args
branch
from
0d73819
to
743e00f
Compare
|
Could someone please check if this is still working with OpenSSH 8.x and on Windows? |
dhoppe
changed the title
I’m not too worried about Windows as the Packer host since the project hasn’t tested with it in the past; however, that said I’m certainly willing to include coverage based on Windows 11 22H2. |
|
I just did an downgrade of OpenSSH and build an image for Ubuntu Server 22.04 LTS. Everything is working as expected. |
tenthirtyam
reviewed
Nov 30, 2022
There was a problem hiding this comment.
- Pass on Ubuntu 22.04 LTS: OpenSSH_8.9p1 Ubuntu-3, OpenSSL 3.0.2 15 Mar 2022
- Fail on macOS Monterey (
12.6.1): OpenSSH_8.6p1, LibreSSL 3.3.6
vsphere-iso.linux-photon: TASK [Gathering Facts] *********************************************************
vsphere-iso.linux-photon: fatal: [default]: FAILED! => {"msg": "failed to transfer file to /Users/johnsonryan/.<sensitive>/tmp/<sensitive>-local-689535utghcqo/tmpf7p_lub9 /home/<sensitive>/.<sensitive>/tmp/<sensitive>-tmp-1669845602.772087-68956-148654805544790/AnsiballZ_setup.py:\n\nscp: illegal option -- O\nusage: scp [-346ABCpqrTv] [-c cipher] [-F ssh_config] [-i identity_file]\n [-J destination] [-l limit] [-o ssh_option] [-P port]\n [-S program] source ... target\n"}Need to test on Photon OS 4.0.
Dropped testing under the following in #393:
- Ubuntu 20.04 LTS
- macOS Big Sur (
11.x)
Plan to test under - pending:
- macOS Ventura (
13.x)
Interesting. I was using macOS Ventura, but did. an downgrade of OpenSSH to version 8.9. I think this is related to the version of OpenSSH and not the operating system. |
dhoppe
force-pushed
the
ansible_ssh_extra_args
branch
from
743e00f
to
75ebcc9
Compare
dhoppe
force-pushed
the
ansible_ssh_extra_args
branch
from
75ebcc9
to
2e0dd57
Compare
tenthirtyam
approved these changes
Dec 1, 2022
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
Adds
HostKeyAlgorithms=+ssh-rsaandPubkeyAcceptedKeyTypes=+ssh-rsaas extra arguments for Ansible.This will set these parameters automatically instead of assuming that the user has read the current documented requirements.
Type of Pull Request
type/bugtype/featureortype/enhancementtype/docstype/refactortype/chorePlease describe:
Related to Existing Issues
Issue Number: N/A
Test and Documentation Coverage
I have tested this for Debian 11 and Ubuntu Server 22.04 LTS. VMware Photon OS 4 did not get pass the boot loader.
Breaking Changes?