Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use build_password and build_password_encrypted for debian #653

Merged
merged 2 commits into from Aug 21, 2023
Merged

fix: use build_password and build_password_encrypted for debian #653

merged 2 commits into from Aug 21, 2023

Conversation

roshankathawate
Copy link
Contributor

@roshankathawate roshankathawate commented Aug 21, 2023 •
edited by tenthirtyam

Summary of Pull Request

This PR fixes issue of SSHing into the VM while creating an debian based OVF. Whitout this fix user gets error 'Timeout waiting for SSH' as SSH credentials could not be set properly on the host. The changes done in this PR are already present for other linux based OSes in their respective linux-*.pkr.hcl file. (e.g. builds/centos/7/linux-centos.pkr.hcl)

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@roshankathawate roshankathawate requested a review from a team as a code owner August 21, 2023 09:13
@vmwclabot
Copy link

@roshankathawate, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

fix: use 'build_password' along with 'build_password_encrypted' to se…
2f7ba0e 
…t host's SSH credentials

Signed-off-by: Roshan Kathawate <kathawatero@vmware.com>
@tenthirtyam tenthirtyam removed the request for review from vmwghbot August 21, 2023 13:18
@tenthirtyam tenthirtyam added this to the .Next milestone Aug 21, 2023
tenthirtyam
tenthirtyam requested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Roshan @roshankathawate!

Would you kindly update the builds/linux/debian/12/linux-debian.pkr.hclfile as well?

Ryan

@tenthirtyam tenthirtyam changed the title fix: use 'build_password' along with 'build_password_encrypted' to se… fix: use build_password and 'build_password_encrypted' for debian Aug 21, 2023
@tenthirtyam tenthirtyam changed the title fix: use build_password and 'build_password_encrypted' for debian fix: use build_password and build_password_encrypted for debian Aug 21, 2023
@tenthirtyam
fix: include debian 12
268c9a5 
- Updated `CHANGELOG.md`.
- Updated Debian 12.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
tenthirtyam approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam
Copy link
Contributor

@roshankathawate I've made the necessary updates for Debian 12 and the CHANGELOG.md.

Please join the vmware-samples org per https://cla.vmware.com/employee and I'll merge.

@tenthirtyam tenthirtyam added the status/awaitng-response Awaiting Response label Aug 21, 2023
tenthirtyam
tenthirtyam approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam merged commit 18f6c73 into vmware-samples:main Aug 21, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@roshankathawate roshankathawate

Labels
size/xs X-Small status/awaitng-response Awaiting Response type/bug Bug
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roshankathawate @vmwclabot @tenthirtyam