feat: add oracle linux

[virtualistic]

Summary of Pull Request

As I requested here:
#659 and inspired by your suggestion, created a new build for Oracle Linux 8. Had to change the menu a bit to "make room" for the Oracle 8 template at position 19. (I skipped position 18 for Oracle 9 in the future). I was able to successfully build a new Oracle 8 template but hopefully you have some time to test and verify this.

Type of Pull Request

• This is a bugfix. type/bug
• This is an enhancement or feature. type/feature or type/enhancement
• This is a documentation update. type/docs
• This is a refactoring update. type/refactor
• This is a chore. type/chore
• This is something else.
  Please describe:

Related to Existing Issues

Closes #671

Test and Documentation Coverage

• Tests have been completed.
• Documentation has been added or updated.

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

[vmwclabot]

@virtualistic, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[vmwclabot]

@virtualistic, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

[tenthirtyam]

The build.yaml needs to be updated. This is used to generated the build.sh with gomplate.

The README.md would also need an update.

[tenthirtyam]

Marked as drafted until the CLA is approved.

[virtualistic]

I added a new commit which added Oracle Linux as an entry to the README
Also added an entry for build.yaml

[tenthirtyam]

Hi @virtualistic -

Please run the following to generate the build.sh:

gomplate -c build.yaml -f build.tmpl -o build.sh

Additionally, in the README.md and update is needed to list the download information for each the distribution:

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

[virtualistic]

Created a new commit that:

• Rebuilt the build.sh using the command:
  gomplate -c build.yaml -f build.tmpl -o build.sh

• Added the source for the Oracle ISO to the README

[tenthirtyam]

Thanks! Once the CLA is approved I'll run the standard tests. I have a couple updates and pull requests that I have in my backlog for this side project but will prioritize as soon as possible.

Might I ask you to open an enhancement issue and link the pull request with "Closes #x" when time permits.

[virtualistic]

Thanks! Once the CLA is approved I'll run the standard tests. I have a couple updates and pull requests that I have in my backlog for this side project but will prioritize as soon as possible.

Might I ask you to open an enhancement issue and link the pull request with "Closes #x" when time permits.

Sure, no problem. ( Enhancement request has a typo btw: "Please add a short decsription." )
When I open a new Enhancement Request, there are several mandatory fields:
Description
Use Case(s)
Potential Configuration
Do I type: "closes # 670" in each field or do you want that placed in a certain field?

[tenthirtyam]

Closes is put here in the PR back to the enhancement issue.

thanks for the note on the issue form! :)

[virtualistic]

closes #671

[virtualistic]

Closes is put here in the PR back to the enhancement issue.

thanks for the note on the issue form! :)

Most welcome!
Please note that the Oracle iso has an annoying mix of CaPs in its filename which I changed to all lowercase after I downloaded the iso and also used the lowercase name in the packer file that references the iso.
So 2 questions:

1. Do you want me to use the original filename of the ISO in this pull request?

2. I also changed the iso_path to iso/misc for my situation in the linux-oel.auto.pkrvars.hcl . Do you want me to change it to iso/linux/oracle for this pull request?

[tenthirtyam]

Please use the original file name from the vendor and an oel or oracle path.

[vmwclabot]

@virtualistic, VMware has approved your signed contributor license agreement.

Second review.

[tenthirtyam]

Minor changes.

Would you consider adding OEL 9?

[virtualistic]

Minor changes.

Would you consider adding OEL 9?

Don't know if v9 will work because the latest vCenter v7 does not offer Oracle Linux 9 as a guest os .
(while my local v7 ESXi server does)

[virtualistic]

I agree with your suggested changes. Think it's best I edit my repo and create a new commit with the changes?
Or should I do a "signoff and commit suggestion" from the GitHub UI?

[tenthirtyam]

I agree with your suggested changes. Think it's best I edit my repo and create a new commit with the changes?
Or should I do a "signoff and commit suggestion" from the GitHub UI?

"signoff and commit suggestion" is fine, but I generally just amend the last commit and force push.

[tenthirtyam]

Don't know if v9 will work because the latest vCenter v7 does not offer Oracle Linux 9 as a guest os . (while my local v7 ESXi server does).

Use other5xLinux64Guest. 😃

[virtualistic]

Ok, I changed all the requested files and did a :

git add -A
git commit --amend --no-edit
git push -f

Will have look if it's easy to add Oracle 9 now using my own Oracle 8 files 😄

[virtualistic]

Ok, pushed a new commit with an Oracle 9 Template.

[tenthirtyam]

Awesome! thank you!!

[tenthirtyam]

LGTM!

[tenthirtyam]

LGTM!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.