Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: debian 11 mount of /dev/sr1 with http data source #686

Merged
merged 2 commits into from Sep 21, 2023
Merged

fix: debian 11 mount of /dev/sr1 with http data source #686

merged 2 commits into from Sep 21, 2023

Conversation

necarnot
Copy link
Contributor

@necarnot necarnot commented Sep 21, 2023 •
edited by tenthirtyam

Summary of Pull Request

Fix Debian 11 mount of /dev/sr1 with http data source.

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: 673

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@necarnot
Fix vmware-samples#685
8217ae1 
 fix: debian mount of /dev/sr1 with http data source vmware-samples#685 

Signed-off-by: necarnot <nicolas@ecarnot.net>
@necarnot necarnot requested a review from a team as a code owner September 21, 2023 14:38
@necarnot necarnot changed the title Fix #685 Fix #673 Sep 21, 2023
@necarnot necarnot mentioned this pull request Sep 21, 2023
Merged
10 tasks
@tenthirtyam tenthirtyam changed the title Fix #673 fix: debian 11 mount of /dev/sr1 with http data source Sep 21, 2023
@tenthirtyam
docs: update CHANGELOG.md
b91fbcf 
Update `CHANGELOG.md`.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
tenthirtyam
tenthirtyam approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam merged commit c957c2b into vmware-samples:develop Sep 21, 2023
@tenthirtyam tenthirtyam added this to the .Next milestone Sep 23, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

@vmwghbot vmwghbot Awaiting requested review from vmwghbot vmwghbot is a code owner automatically assigned from vmware-samples/packer-examples-for-vsphere-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@necarnot @tenthirtyam