Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add logging to set-envvars.sh #705

Merged
merged 1 commit into from Sep 26, 2023
Merged

feat: add logging to set-envvars.sh #705

merged 1 commit into from Sep 26, 2023

Conversation

tenthirtyam
Copy link
Contributor

Summary of Pull Request

Adds Packer logging settings to set-envvars.sh.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Related #697

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Sep 26, 2023
@tenthirtyam tenthirtyam added this to the .Next milestone Sep 26, 2023
@tenthirtyam tenthirtyam self-assigned this Sep 26, 2023
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Sep 26, 2023
@tenthirtyam
feat: add logging to set-envvars.sh
8f8318c 
Adds Packer logging settings to `set-envvars.sh`.

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam marked this pull request as ready for review September 26, 2023 03:20
@tenthirtyam tenthirtyam requested a review from a team as a code owner September 26, 2023 03:20
@tenthirtyam tenthirtyam requested review from vmwghbot and rcroft-work and removed request for vmwghbot September 26, 2023 03:20
rcroft-work
rcroft-work approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@rcroft-work rcroft-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tenthirtyam tenthirtyam merged commit 6eaf7b7 into develop Sep 26, 2023
@tenthirtyam tenthirtyam deleted the feat/add-logging-envvars branch September 26, 2023 05:00
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcroft-work rcroft-work rcroft-work approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
cla-not-required Contributor License Agreement Not Required type/enhancement Enhancement
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tenthirtyam @rcroft-work @vmwclabot