Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add debug #706

Merged
merged 1 commit into from Sep 29, 2023
Merged

feat: add debug #706

merged 1 commit into from Sep 29, 2023

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Sep 26, 2023

Summary of Pull Request

  • Adds --help / -h option to ./build.sh for help.
  • Adds --debug / -d option to ./build.sh for debug mode.
  • Updates README.md.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #697

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Sep 26, 2023
@tenthirtyam tenthirtyam added this to the .Next milestone Sep 26, 2023
@tenthirtyam tenthirtyam self-assigned this Sep 26, 2023
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Sep 26, 2023
@tenthirtyam tenthirtyam marked this pull request as ready for review September 26, 2023 05:00
@tenthirtyam tenthirtyam requested a review from a team as a code owner September 26, 2023 05:00
@tenthirtyam tenthirtyam force-pushed the feat/add-debug branch 3 times, most recently from 75115b2 to 0f0481a Compare September 28, 2023 23:56
build.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@rcroft-work rcroft-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with change.

@tenthirtyam tenthirtyam force-pushed the feat/add-debug branch 2 times, most recently from 3091ddd to 796194d Compare September 29, 2023 19:13
- Adds `--help` / `-h` option to `./build.sh` for help.
- Adds `--debug` / `-d` option to `./build.sh` for debug mode.

Ref: #697

Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
@tenthirtyam tenthirtyam merged commit 12dd9a3 into develop Sep 29, 2023
@tenthirtyam tenthirtyam deleted the feat/add-debug branch September 29, 2023 19:26
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option run builds in debug mode
4 participants