Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional configuration options #771

Merged

Conversation

DavidRobson
Copy link
Contributor

@DavidRobson DavidRobson commented Nov 9, 2023

Summary of Pull Request

Adds support for setting additional packer configuration options (resource_pool, set_host_for_datastore_uploads and ip_settle_timeout).

I came across issues on one of our vSphere environments and had to set additional parameters. I have seen various discussions where other users mentioned setting the same parameters on certain configurations so I think it would be useful to include these as options in this project that users can set if they would like.

I set default values for these so any existing deployments people have should not break as it should use the defaults and behave as before.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #772

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@DavidRobson DavidRobson requested a review from a team as a code owner November 9, 2023 06:14
@vmwclabot
Copy link

@DavidRobson, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@tenthirtyam
Copy link
Contributor

Hi @DavidRobson! 👋

Thank you for the contribution!

Please sign the VMware CLA and an enhancement issue per the contributing guidelines. Then link the pull request to the issue.

Thank you!

Ryan

@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Nov 9, 2023
@tenthirtyam tenthirtyam added this to the .Next milestone Nov 9, 2023
@tenthirtyam tenthirtyam marked this pull request as draft November 9, 2023 13:51
@tenthirtyam
Copy link
Contributor

Marked as draft until CLA is signed and enhancement issue is created.

@vmwclabot
Copy link

@DavidRobson, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@DavidRobson
Copy link
Contributor Author

@tenthirtyam raised a new issue and linked it, and signed the CLA. I guess we just need to wait for the CLA to be reviewed now.

@tenthirtyam
Copy link
Contributor

Thank you! Will merge once the CLA is approved by our OS team.

@vmwclabot
Copy link

@DavidRobson, VMware has approved your signed contributor license agreement.

@tenthirtyam tenthirtyam marked this pull request as ready for review November 10, 2023 11:16
@tenthirtyam
Copy link
Contributor

I'll get this merged today.

@tenthirtyam tenthirtyam changed the title feat: add additional packer configuration options feat: add additional configuration options Nov 10, 2023
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Signed-off-by: David Robson <david.robson@quest.com>
@tenthirtyam tenthirtyam merged commit 4cc44d8 into vmware-samples:develop Nov 10, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional packer configuration options
3 participants