-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add additional configuration options #771
feat: add additional configuration options #771
Conversation
@DavidRobson, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
04be56b
to
39350d9
Compare
Hi @DavidRobson! 👋 Thank you for the contribution! Please sign the VMware CLA and an enhancement issue per the contributing guidelines. Then link the pull request to the issue. Thank you! Ryan |
Marked as draft until CLA is signed and enhancement issue is created. |
@DavidRobson, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
@tenthirtyam raised a new issue and linked it, and signed the CLA. I guess we just need to wait for the CLA to be reviewed now. |
Thank you! Will merge once the CLA is approved by our OS team. |
@DavidRobson, VMware has approved your signed contributor license agreement. |
I'll get this merged today. |
39350d9
to
495e6ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Signed-off-by: David Robson <david.robson@quest.com>
495e6ab
to
b6b44de
Compare
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary of Pull Request
Adds support for setting additional packer configuration options (resource_pool, set_host_for_datastore_uploads and ip_settle_timeout).
I came across issues on one of our vSphere environments and had to set additional parameters. I have seen various discussions where other users mentioned setting the same parameters on certain configurations so I think it would be useful to include these as options in this project that users can set if they would like.
I set default values for these so any existing deployments people have should not break as it should use the defaults and behave as before.
Type of Pull Request
type/bug
type/feature
ortype/enhancement
type/docs
type/refactor
type/chore
Please describe:
Related to Existing Issues
Closes #772
Test and Documentation Coverage
Breaking Changes?