Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional packages #800

Merged
merged 4 commits into from Dec 18, 2023

Conversation

sestegra
Copy link
Contributor

@sestegra sestegra commented Dec 16, 2023

Summary of Pull Request

Adds additional configuration to install packages for Linux Distributions.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #694

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@sestegra sestegra requested a review from a team as a code owner December 16, 2023 19:19
@sestegra
Copy link
Contributor Author

My lab is broken, I can't test right now.
I did tests on the templating only.

tenthirtyam
tenthirtyam previously approved these changes Dec 16, 2023
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Mind updating the CHANGELOG.md and I’ll merge?

@tenthirtyam
Copy link
Contributor

My lab is broken, I can't test right now. I did tests on the templating only.

I’ll run the tests beginning of the week.

sestegra and others added 4 commits December 18, 2023 12:44
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
Signed-off-by: Stéphane Este-Gracias <sestegra@gmail.com>
Format with `packer fmt -recursive`.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam merged commit 7fee81c into vmware-samples:develop Dec 18, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to dynamically customize Linux package selections
2 participants