-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for ansible integration for windows images #801
Conversation
@gcblack, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
e3799e9
to
844cd3e
Compare
785d837
to
9416be9
Compare
9aab957
to
3e916cb
Compare
@gcblack, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
@gcblack, VMware has approved your signed contributor license agreement. |
f6abcae
to
e1a9c46
Compare
675d244
to
ed554ec
Compare
Hi Ryan/Allan, Have been testing this PR in our environment where I can build Windows 10/11 and Windows Server 2025 Insiders Preview. However, I still have issues with Windows Server 2019/2022 and the "updating operating system" task - see attached Also, have some minor changes remove warnings/etc but do not have the permissions to update the PR so have attached the changes as a git patch - see 0001-Tidy-up-packer-warnings-for-Ansible-support-for-Wind.patch |
ed554ec
to
b8d374d
Compare
Thanks, Richard! I've applied the patch!! |
e09086d
to
cd3519a
Compare
I have made some updates in cd3519a ; however, I am seeing the same issues for Windows Server 2019/2022 with Ansible updating the operating system but works as expected on Windows 10/11. |
The Ansible seen during a build seem to be related to MS KB5034439 (Jan 09 2024) and the WinRE partition, but using a larger size does not correct the issue. |
2604943
to
b5bc488
Compare
Workaround: - name: "Updating the operating system."
ansible.windows.win_updates:
category_names:
- SecurityUpdates
- CriticalUpdates
reject_list:
- 5034439
reboot: true |
f8cbeee
to
16a0d4e
Compare
Add support for Ansible integration for Windows images. Signed-off-by: Allan Scott <alnscott@amazon.com> Co-Authored-By: Ryan Johnson <ryan.johnson@broadcom.com>
16a0d4e
to
dfcb82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary of Pull Request
Add support for Ansible integration for Windows images:
windows-prepare.ps1
script to the newly added Ansible provisioner.windows_update
provisioner and added that update task to the Ansible provisioner.Type of Pull Request
type/bug
type/feature
ortype/enhancement
type/docs
type/refactor
type/chore
Please describe:
Related to Existing Issues
Issue Number: N/A
Test and Documentation Coverage
Breaking Changes?