Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: growing ubuntu lvm partition #805

Merged
merged 5 commits into from
Jan 12, 2024
Merged

feat: growing ubuntu lvm partition #805

merged 5 commits into from
Jan 12, 2024

Conversation

alcorwalter
Copy link
Contributor

Summary of Pull Request

For Ubuntu using autoinstall, add the possibility of using the value "-1" for the size of the last LVM partition, so that it uses the remaining space in the Volume Group.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Resolves #803

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@alcorwalter alcorwalter requested a review from a team as a code owner January 11, 2024 22:02
@vmwclabot
Copy link

@alcorwalter, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@alcorwalter alcorwalter changed the title Feat/growing ubuntu lvm partition feat: growing ubuntu lvm partition Jan 11, 2024
@vmwclabot
Copy link

@alcorwalter, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@alcorwalter
Copy link
Contributor Author

Successful test of a VMware template for Ubuntu 22.04 LTS

@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Jan 11, 2024
@tenthirtyam tenthirtyam added this to the Backlog milestone Jan 11, 2024
@tenthirtyam tenthirtyam changed the base branch from develop to feat/update-winrm-config January 12, 2024 00:28
@vmwclabot
Copy link

@alcorwalter, VMware has approved your signed contributor license agreement.

@tenthirtyam tenthirtyam changed the base branch from feat/update-winrm-config to develop January 12, 2024 12:17
@tenthirtyam tenthirtyam modified the milestones: Backlog, .Next Jan 12, 2024
@tenthirtyam
Copy link
Contributor

I've resolved the conflicts.

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see open conversations that need resolution.

builds/linux-storage.pkrvars.hcl.example Show resolved Hide resolved
builds/linux-storage.pkrvars.hcl.example Show resolved Hide resolved
@tenthirtyam tenthirtyam marked this pull request as draft January 12, 2024 12:18
@tenthirtyam tenthirtyam marked this pull request as ready for review January 12, 2024 16:39
@tenthirtyam tenthirtyam self-requested a review January 12, 2024 16:39
@tenthirtyam tenthirtyam removed the request for review from vmwghbot January 12, 2024 16:54
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I pushed some minor updates to include this.

@tenthirtyam tenthirtyam merged commit 4ad7ee1 into vmware-samples:develop Jan 12, 2024
@alcorwalter alcorwalter deleted the feat/growing-ubuntu-lvm-partition branch January 16, 2024 08:43
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LVM partition taking into account remaining space on Volume Group
3 participants