Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Windows Server 2025 Insiders Preview #834

Merged

Conversation

rcroft-work
Copy link
Contributor

Summary of Pull Request

This PR adds support for Windows Server 2025 Insiders Previews to enable customers to try/test these releases.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Resolves: #833
Issue Number: #833

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Updated the changelog.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@rcroft-work rcroft-work requested a review from a team as a code owner January 31, 2024 00:15
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Jan 31, 2024
@rcroft-work rcroft-work force-pushed the add-winsrv-2025-insiders branch 2 times, most recently from fb795dd to 929dee7 Compare January 31, 2024 00:23
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - needs an update to the README.md and the /docs for the OS listings

@tenthirtyam
Copy link
Contributor

@rcroft-work
Copy link
Contributor Author

Done, docs/index.md updated.

@rcroft-work
Copy link
Contributor Author

Okay, now docs/index.md really has been updated.

Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LHTM!

@tenthirtyam tenthirtyam merged commit 95d84e8 into vmware-samples:develop Jan 31, 2024
@rcroft-work rcroft-work deleted the add-winsrv-2025-insiders branch February 1, 2024 00:21
Copy link

github-actions bot commented Mar 2, 2024

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Windows Server 2025 Insiders Preview
3 participants