Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remaining cdrom count #836

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Feb 13, 2024

Summary of Pull Request

Adds the ability to complete an image with a specified number of remaining CD-ROMs added in packer-plugin-vsphere v1.2.4.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Adds the ability to complete an image with a specified number of remaining CD-ROMs added in `packer-plugin-vsphere` v1.2.4.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Feb 13, 2024
@tenthirtyam tenthirtyam added this to the .Next milestone Feb 13, 2024
@tenthirtyam tenthirtyam self-assigned this Feb 13, 2024
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Feb 13, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review February 13, 2024 18:49
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 13, 2024 18:49
@tenthirtyam tenthirtyam merged commit 3cb9ccf into develop Feb 13, 2024
1 check passed
@tenthirtyam tenthirtyam deleted the feat/remaining-cdrom-count branch February 13, 2024 18:49
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants