Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ubuntu cloud-init #843

Merged
merged 1 commit into from
Mar 28, 2024
Merged

refactor: ubuntu cloud-init #843

merged 1 commit into from
Mar 28, 2024

Conversation

tenthirtyam
Copy link
Contributor

@tenthirtyam tenthirtyam commented Feb 19, 2024 •
edited
Loading

Summary of Pull Request

Refactors the Ubuntu image builds not to use cloud-init by default.

Set vm_guest_os_cloudinit to true to enable cloud-init on the machine image.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Testing is TBA.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the type/refactor Refactor label Feb 19, 2024
@tenthirtyam tenthirtyam added this to the .Next milestone Feb 19, 2024
@tenthirtyam tenthirtyam self-assigned this Feb 19, 2024
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Feb 19, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review February 22, 2024 20:06
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 22, 2024 20:06
@tenthirtyam tenthirtyam requested review from GaryJBlake and rcroft-work and removed request for GaryJBlake February 22, 2024 20:06
@tenthirtyam tenthirtyam force-pushed the feet/ubuntu-cloudinit branch 2 times, most recently from cff642b to 3ecc4f6 Compare March 27, 2024 22:19
@tenthirtyam
refactor: ubuntu cloud-init
08fbd31 
Refactors the Ubuntu image builds **not** to use cloud-init by default. Set `vm_guest_os_cloudinit` to `true` to enable cloud-init on the machine image

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
Co-Authored-By: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam merged commit fcfce8f into develop Mar 28, 2024
@tenthirtyam tenthirtyam deleted the feet/ubuntu-cloudinit branch March 28, 2024 00:35
@tenthirtyam tenthirtyam mentioned this pull request Apr 22, 2024
Closed
1 task
@tenthirtyam tenthirtyam linked an issue Apr 23, 2024 that may be closed by this pull request
Add support for cloud-init for each Linux distribution #691
Closed
1 task
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcroft-work rcroft-work Awaiting requested review from rcroft-work

Assignees

@tenthirtyam tenthirtyam

Labels
cla-not-required Contributor License Agreement Not Required type/refactor Refactor
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.

Add support for cloud-init for each Linux distribution
2 participants
@tenthirtyam @vmwclabot