Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use windows os evaluation #844

Merged
merged 1 commit into from Mar 27, 2024
Merged

feat: use windows os evaluation #844

merged 1 commit into from Mar 27, 2024

Conversation

gcblack
Copy link
Contributor

@gcblack gcblack commented Feb 20, 2024 •
edited by tenthirtyam

Summary of Pull Request

Adds the option to build the Windows image using the evaluation, by default, with the vm_inst_os_eval variable.

If set to true (default), the image is built with evaluation, else it will look for a provided key.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@gcblack gcblack requested a review from a team as a code owner February 20, 2024 19:38
@tenthirtyam tenthirtyam changed the title Win iso trial feat: use windows os evaluation Feb 20, 2024
@tenthirtyam tenthirtyam added this to the .Next milestone Feb 20, 2024
@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Feb 20, 2024
@tenthirtyam tenthirtyam removed the request for review from vmwghbot February 20, 2024 20:11
@tenthirtyam tenthirtyam marked this pull request as draft February 20, 2024 20:13
@tenthirtyam tenthirtyam force-pushed the win-iso-trial branch 3 times, most recently from e261999 to b7e306b Compare February 21, 2024 17:28
@tenthirtyam tenthirtyam marked this pull request as ready for review February 21, 2024 17:41
@tenthirtyam tenthirtyam self-requested a review February 21, 2024 17:41
@alnscott @tenthirtyam
feat: use windows os evaluation
bfe7d08 
Adds the option to build the Windows image using the evaluation, **by default**, with the `vm_inst_os_eval` variable.

If set to `true` (default), the image is built with evaluation, else it will look for a provided key.

Co-Authored-By: Ryan Johnson <ryan@tenthirtyam.org>
tenthirtyam
tenthirtyam approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested! 🚀

@tenthirtyam tenthirtyam merged commit bcff257 into vmware-samples:develop Mar 27, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

@rcroft-work rcroft-work Awaiting requested review from rcroft-work

Assignees

@gcblack gcblack

Labels
type/enhancement Enhancement
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gcblack @tenthirtyam @alnscott