Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added cloud-init to centos stream 8 and 9 #897

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented Apr 22, 2024

Summary of Pull Request

  • Added the cloud-init option for CentOS Stream 9.
  • Added the cloud-init option for CentOS Stream 8.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Ref: #691

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@burnsjared0415 burnsjared0415 requested a review from a team as a code owner April 22, 2024 19:59
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label Apr 22, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/installed-cloud-init-on-Centos branch from 30c104b to 0d08394 Compare April 22, 2024 20:00
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions added.

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam changed the title feat: added cloud-init to Centos 8 and Centos 9 feat: added cloud-init to centos stream 8 and 9 Apr 23, 2024
@tenthirtyam tenthirtyam added the type/enhancement Enhancement label Apr 23, 2024
@tenthirtyam tenthirtyam added this to the v0.20.0 milestone Apr 23, 2024
@tenthirtyam tenthirtyam linked an issue Apr 23, 2024 that may be closed by this pull request
1 task
@burnsjared0415 burnsjared0415 force-pushed the feat/installed-cloud-init-on-Centos branch from 0d08394 to b3269a4 Compare April 23, 2024 12:38
Added cloud init to Centos 8 and Centos 9.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@burnsjared0415 burnsjared0415 force-pushed the feat/installed-cloud-init-on-Centos branch from b3269a4 to 178af36 Compare April 23, 2024 12:58
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit 8a1f41e into vmware-samples:develop Apr 23, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required Contributor License Agreement Not Required type/enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for cloud-init for each Linux distribution
3 participants