Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added 9.4 versions and updated build.sh #927

Merged
merged 2 commits into from
May 20, 2024
Merged

chore: added 9.4 versions and updated build.sh #927

merged 2 commits into from
May 20, 2024

Conversation

burnsjared0415
Copy link
Contributor

@burnsjared0415 burnsjared0415 commented May 20, 2024 •
edited by tenthirtyam
Loading

Summary of Pull Request

  • Refactors depedencies check build.sh.
  • Updates Oracle Linux 9 to 9.4 release.
  • Updates Almalinux 9 to 9.4 release.
  • Updates Rocky Linux 9 to 9.4 release.

Type of Pull Request

  • This is a bugfix. type/bug
  • This is an enhancement or feature. type/feature or type/enhancement
  • This is a documentation update. type/docs
  • This is a refactoring update. type/refactor
  • This is a chore. type/chore
  • This is something else.
    Please describe:

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed.
  • Documentation has been added or updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam
refactor: update download.sh (vmware-samples#926)
a8f40d8 
Enhances the dependency checks.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@burnsjared0415 burnsjared0415 requested a review from a team as a code owner May 20, 2024 20:17
@vmwclabot vmwclabot added the cla-not-required Contributor License Agreement Not Required label May 20, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/updated-build-for-deps-and-add-9.4-version branch from 6578429 to 53b5801 Compare May 20, 2024 20:20
@tenthirtyam tenthirtyam added this to the v0.20.0 milestone May 20, 2024
@tenthirtyam tenthirtyam requested review from tenthirtyam and removed request for GaryJBlake May 20, 2024 20:21
@tenthirtyam tenthirtyam changed the title feat: added 9.4 versions and updated build.sh chore: added 9.4 versions and updated build.sh May 20, 2024
@tenthirtyam tenthirtyam added the type/chore Chore label May 20, 2024
@burnsjared0415 burnsjared0415 force-pushed the feat/updated-build-for-deps-and-add-9.4-version branch from 53b5801 to 8cfe6ca Compare May 20, 2024 21:16
@tenthirtyam tenthirtyam force-pushed the feat/updated-build-for-deps-and-add-9.4-version branch 2 times, most recently from 0b3863e to a59c309 Compare May 20, 2024 21:37
@burnsjared0415 @tenthirtyam
feat: added 9.4 versions and updated build.sh
e5c8cc2 
- Refactors depedencies check build.sh.
- Updates Oracle Linux 9 to 9.4 release.
- Updates Almalinux 9 to 9.4 release.
- Updates Rocky Linux 9 to 9.4 release.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the feat/updated-build-for-deps-and-add-9.4-version branch from a59c309 to e5c8cc2 Compare May 20, 2024 21:39
tenthirtyam
tenthirtyam approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and Approved!

@tenthirtyam tenthirtyam merged commit cd4cff4 into vmware-samples:develop May 20, 2024
tenthirtyam pushed a commit that referenced this pull request May 20, 2024
@burnsjared0415 @tenthirtyam
chore: update rhel-variant to 9.4 versions and updated build.sh (#927)
077ff06 
- Refactors dependencies check `build.sh`.
- Updates Oracle Linux 9 to 9.4 release.
- Updates Almalinux 9 to 9.4 release.
- Updates Rocky Linux 9 to 9.4 release.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
tenthirtyam pushed a commit that referenced this pull request May 20, 2024
@burnsjared0415 @tenthirtyam
chore: update rhel-variant to 9.4 versions and updated build.sh (#927)
4c2a07d 
- Refactors dependencies check `build.sh`.
- Updates Oracle Linux 9 to 9.4 release.
- Updates Almalinux 9 to 9.4 release.
- Updates Rocky Linux 9 to 9.4 release.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
tenthirtyam pushed a commit that referenced this pull request May 20, 2024
@burnsjared0415 @tenthirtyam
chore: update rhel-variant to 9.4 versions and updated build.sh (#927)
952a917 
- Refactors dependencies check `build.sh`.
- Updates Oracle Linux 9 to 9.4 release.
- Updates Almalinux 9 to 9.4 release.
- Updates Rocky Linux 9 to 9.4 release.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
tenthirtyam pushed a commit that referenced this pull request May 21, 2024
@burnsjared0415 @tenthirtyam
chore: update rhel-variant to 9.4 versions and updated build.sh (#927)
113ea37 
- Refactors dependencies check `build.sh`.
- Updates Oracle Linux 9 to 9.4 release.
- Updates Almalinux 9 to 9.4 release.
- Updates Rocky Linux 9 to 9.4 release.

Signed-off-by: Jared Burns <jared.burns@broadcom.com>
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@burnsjared0415 burnsjared0415

Labels
cla-not-required Contributor License Agreement Not Required type/chore Chore
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@burnsjared0415 @tenthirtyam @vmwclabot