Reject unsupported postional arguments for antctl #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Apr 1, 2021
pkg/antctl/raw/proxy/command.go
Outdated
| @@ -132,6 +132,12 @@ func init() { | |||
| Long: "Run a reverse proxy to access Antrea API (Controller or Agent). Command only supports remote mode. HTTPS connections between the proxy and the Antrea API will not be secure (no certificate verification).", | |||
| Example: proxyCommandExample, | |||
| RunE: runE, | |||
| Args: func(cmd *cobra.Command, args []string) error { | |||
There was a problem hiding this comment.
can't we use the builtin args: NoArgs command validator here? See https://pkg.go.dev/github.com/spf13/cobra#readme-positional-and-custom-arguments
There was a problem hiding this comment.
Yes. Didn't notice that before.
antoninbas
reviewed
Apr 1, 2021
I'm not sure how to write unit test but I will try it. |
hty690
force-pushed
the
traceflow_reject
branch
2 times, most recently
from
1bcf499
to
d3b1511
Compare
Codecov Report
@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
- Coverage 65.39% 57.15% -8.25%
==========================================
Files 197 262 +65
Lines 17217 19469 +2252
==========================================
- Hits 11259 11127 -132
- Misses 4785 7166 +2381
- Partials 1173 1176 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hty690
force-pushed
the
traceflow_reject
branch
2 times, most recently
from
dad13af
to
dc7dab0
Compare
jianjuns
previously approved these changes
Apr 1, 2021
antoninbas
reviewed
Apr 1, 2021
For traceflow and proxy, antctl will fail and log error when the user enters extra postional arguments. Fixes antrea-io#1915
jianjuns
approved these changes
Apr 2, 2021
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For traceflow and proxy, antctl will fail and log error when the user
enters extra postional arguments.
Before:
After:
Fixes #1915