support various pod traffic encapsulation mode #340

suwang48404 · 2020-01-22T23:03:26Z

Design doc
https://docs.google.com/document/d/1X-UXz38XcFfLkjWE_5ke_g-WYRwsTaA04182OGDtO4g/edit#heading=h.8haslsej50qf

antrea-bot · 2020-01-22T23:03:44Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-all: to trigger all tests.
/skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

antrea-bot · 2020-01-23T02:45:53Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-all: to trigger all tests.
/skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

suwang48404 · 2020-01-23T03:48:09Z

/test-e2e
/test-conformance
/test-networkpolicy

suwang48404 · 2020-01-23T03:50:39Z

/test-all

suwang48404 · 2020-01-24T01:25:05Z

/test-all

suwang48404 · 2020-01-24T01:33:03Z

/test-all

suwang48404 · 2020-01-24T01:43:46Z

/test-e2e

antoninbas · 2020-01-24T01:49:32Z

/test-all

suwang48404 · 2020-01-24T02:36:03Z

/test-all

suwang48404 · 2020-02-11T04:27:51Z

/test-all

antoninbas

One more comment for the test script.

Otherwise, the changes (including changes to kind.yml) look good to me.

ci/kind/test-e2e-kind.sh

.github/workflows/kind.yml

to run integration test in container.

antrea-bot · 2020-02-11T18:57:28Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-all: to trigger all tests.
/skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

antrea-bot · 2020-02-11T18:58:44Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-all: to trigger all tests.
/skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

- kind e2e tests now runs a separete e2e on each of encap mode: encap, hybrid, noEncap - misc: move test-integratin to test-integration-docker to allow more disruptive integration tests in futher.

suwang48404 · 2020-02-11T18:59:36Z

/test-all

antrea-bot · 2020-02-11T18:59:38Z

Thanks for your PR.
Unit tests and code linters are run automatically every time the PR is updated.
E2e, conformance and network policy tests can only be triggered by a member of the vmware-tanzu organization. Regular contributors to the project should join the org.

The following commands are available:

/test-e2e: to trigger e2e tests.
/skip-e2e: to skip e2e tests.
/test-conformance: to trigger conformance tests.
/skip-conformance: to skip conformance tests.
/test-networkpolicy: to trigger networkpolicy tests.
/skip-networkpolicy: to skip networkpolicy tests.
/test-all: to trigger all tests.
/skip-all: to skip all tests.

These commands can only be run by members of the vmware-tanzu organization.

suwang48404 · 2020-02-11T19:01:11Z

/test-all

antoninbas

@jianjuns I'm done with my review. Things look good on my side.

suwang48404 · 2020-02-11T19:16:51Z

/test-conformance

suwang48404 · 2020-02-11T19:18:10Z

/test-all

suwang48404 · 2020-02-11T19:39:46Z

/test-conformance

suwang48404 · 2020-02-11T20:04:24Z

/test-conformance

suwang48404 · 2020-02-11T20:12:30Z

/test-conformance
/test-networkpolicy

suwang48404 · 2020-02-11T20:36:37Z

/test-conformance

suwang48404 · 2020-02-11T20:37:17Z

/test-networkpolicy

suwang48404 · 2020-02-11T21:00:07Z

@jianjuns can u provide approval now?

jianjuns

Great we completed review of this big PR. Great work @suwang48404 and all reviewers!

vmwclabot added the cla-not-required label Jan 22, 2020

suwang48404 changed the title ~~WIP: suport various pod traffic encapsulation mode~~ WIP: support various pod traffic encapsulation mode Jan 22, 2020

suwang48404 force-pushed the noencap branch 2 times, most recently from 175b900 to 5bffd96 Compare January 23, 2020 02:45

suwang48404 requested review from jianjuns, tnqn and antoninbas January 23, 2020 03:45

suwang48404 force-pushed the noencap branch from 5bffd96 to 9da24c4 Compare January 24, 2020 01:24

suwang48404 force-pushed the noencap branch from 9da24c4 to b2ca30c Compare January 24, 2020 01:32

suwang48404 force-pushed the noencap branch from b2ca30c to 6148711 Compare January 24, 2020 01:40

suwang48404 force-pushed the noencap branch from 6148711 to f4e9d04 Compare January 24, 2020 02:35

suwang48404 force-pushed the noencap branch 10 times, most recently from 5fcf731 to e2e9f8d Compare January 24, 2020 08:54

suwang48404 force-pushed the noencap branch 2 times, most recently from 9936850 to c83a1d3 Compare February 11, 2020 04:23

antoninbas reviewed Feb 11, 2020

View reviewed changes

ci/kind/test-e2e-kind.sh Outdated Show resolved Hide resolved

.github/workflows/kind.yml Show resolved Hide resolved

suwang48404 force-pushed the noencap branch 2 times, most recently from 82bbc8b to c892faf Compare February 11, 2020 18:51

Su Wang added 2 commits February 11, 2020 10:52

Added docker-test-integration target

99bcd17

to run integration test in container.

Support multiple encap mode.

31e555f

suwang48404 force-pushed the noencap branch from c892faf to 3a68861 Compare February 11, 2020 18:57

suwang48404 force-pushed the noencap branch from 3a68861 to 550c6e5 Compare February 11, 2020 18:58

incorporate pod traffic encapsulation mode into kind e2e tests.

b774f32

- kind e2e tests now runs a separete e2e on each of encap mode: encap, hybrid, noEncap - misc: move test-integratin to test-integration-docker to allow more disruptive integration tests in futher.

suwang48404 force-pushed the noencap branch from 550c6e5 to b774f32 Compare February 11, 2020 18:59

antoninbas reviewed Feb 11, 2020

View reviewed changes

jianjuns approved these changes Feb 11, 2020

View reviewed changes

jianjuns merged commit 3127843 into antrea-io:master Feb 11, 2020

suwang48404 mentioned this pull request Feb 11, 2020

support for noEncap mode #237

Closed

suwang48404 deleted the noencap branch March 16, 2020 17:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support various pod traffic encapsulation mode #340

support various pod traffic encapsulation mode #340

suwang48404 commented Jan 22, 2020 •

edited

Loading

antrea-bot commented Jan 22, 2020

antrea-bot commented Jan 23, 2020

suwang48404 commented Jan 23, 2020

suwang48404 commented Jan 23, 2020

suwang48404 commented Jan 24, 2020

suwang48404 commented Jan 24, 2020

suwang48404 commented Jan 24, 2020

antoninbas commented Jan 24, 2020

suwang48404 commented Jan 24, 2020

suwang48404 commented Feb 11, 2020

antoninbas left a comment

antrea-bot commented Feb 11, 2020

antrea-bot commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

antrea-bot commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

antoninbas left a comment

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

jianjuns left a comment

support various pod traffic encapsulation mode #340

support various pod traffic encapsulation mode #340

Conversation

suwang48404 commented Jan 22, 2020 • edited Loading

antrea-bot commented Jan 22, 2020

antrea-bot commented Jan 23, 2020

suwang48404 commented Jan 23, 2020

suwang48404 commented Jan 23, 2020

suwang48404 commented Jan 24, 2020

suwang48404 commented Jan 24, 2020

suwang48404 commented Jan 24, 2020

antoninbas commented Jan 24, 2020

suwang48404 commented Jan 24, 2020

suwang48404 commented Feb 11, 2020

antoninbas left a comment

Choose a reason for hiding this comment

antrea-bot commented Feb 11, 2020

antrea-bot commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

antrea-bot commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

antoninbas left a comment

Choose a reason for hiding this comment

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

suwang48404 commented Feb 11, 2020

jianjuns left a comment

Choose a reason for hiding this comment

suwang48404 commented Jan 22, 2020 •

edited

Loading