-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support providing serviceAccountName with create/update/apply commands #76
Conversation
6e6e508
to
85a3b71
Compare
…ommands serviceAccountName, as part of spec in workload, can be now set in a yaml file, as well as deleted. Just adding something like the following in the workload yaml file, this specification will be taken by the supply chain --- apiVersion: carto.run/v1alpha1 kind: Workload metadata: {} spec: ... serviceAccountName: <string> ... If this property doesn't belong to the workload anymore, it can be deleted by simply removing it from the yaml file and then using update/apply commands. Signed-off by: Wendy Arango warango@vmware.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for workload create/update/apply In the supplied yaml has serviceAccountName=""
, removes the serviceAccountName
field from workload.
Pull request
What this PR does / why we need it
Add support to se serviceAccountName property in a workload yaml file.
It can be added while created or added after creation in yaml file and using update/apply commands for the workload to change
Which issue(s) this PR fixes
Fixes #64
Describe testing done for PR
spec
, used both,update
andapply
commands to check if the change was taken.Additional information or special notes for your reviewer
Signed-off by: Wendy Arango warango@vmware.com