Support providing serviceAccountName with create/update/apply commands #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Create a workload with
|
|
Delete
|
|
Change current
|
warango4
force-pushed
the
issue64
branch
2 times, most recently
from
6e6e508
to
85a3b71
Compare
…ommands
serviceAccountName, as part of spec in workload, can be now set in a yaml file, as well as deleted.
Just adding something like the following in the workload yaml file, this specification will be taken by the supply chain
---
apiVersion: carto.run/v1alpha1
kind: Workload
metadata: {}
spec:
...
serviceAccountName: <string>
...
If this property doesn't belong to the workload anymore, it can be deleted by simply removing it from the yaml file and then using update/apply commands.
Signed-off by: Wendy Arango warango@vmware.com
rashedkvm
reviewed
Apr 20, 2022
|
Deleting
|
rashedkvm
approved these changes
Apr 20, 2022
AcceptanceLooks good overall however... if I execute any update that doesn't include |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
What this PR does / why we need it
Add support to se serviceAccountName property in a workload yaml file.
It can be added while created or added after creation in yaml file and using update/apply commands for the workload to change
Which issue(s) this PR fixes
Fixes #64
Describe testing done for PR
spec, used both,updateandapplycommands to check if the change was taken.Additional information or special notes for your reviewer
Signed-off by: Wendy Arango warango@vmware.com