Generate webhooks with kubebuilder #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elated-stonebraker-105904 canceled.
|
cirocosta
reviewed
Mar 24, 2022
| #@ load("@ytt:overlay", "overlay") | ||
|
|
||
| #@overlay/match by=overlay.subset({"kind": "ValidatingWebhookConfiguration"}) | ||
|
|
There was a problem hiding this comment.
oh interesting, nice that we can do all the changes we need right here with a single overlay 👍
|
huh, quite a few errors that I imagine are unrelated coming from CI:
|
cirocosta
approved these changes
Mar 24, 2022
cirocosta
reviewed
Mar 24, 2022
|
for anyone looking at this PR - note that we end up with one less vs but, in the end, we're registering validation for the same gvrs as before (just in a single object instead). |
idoru
requested changes
Mar 24, 2022
idoru
approved these changes
Mar 24, 2022
* Register cluster run template webhook Co-authored-by: Marty Spiewak <mspiewak@vmware.com>
martyspiewak
force-pushed
the
kubebuilder-webhooks
branch
from
3c71ccd
to
baaaaed
Compare
Co-authored-by: Marty Spiewak <mspiewak@vmware.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
closes #
Release Note
PR Checklist
Note: Please do not remove items. Mark items as done
[x]or usestrikethroughif you believe they are not relevantFixes #123orUpdates #123wipcommits