Add builder creation prior to building images on buildkit #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppforlife
reviewed
Nov 25, 2020
cppforlife
reviewed
Nov 25, 2020
The `buildkit` tests are sometimes flaky due to the fact that we are trying to create 2 images in parallel. When we try to do this `buildkit` will try to create a builder, if it doesn't exist, in parallel which causes a failure. This commit ensures that the builder is created before we try to run the parallel test to prevent the above-described issue
joaopapereira
force-pushed
the
buildkit-race-condition-tests
branch
from
df25941
to
d8277cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
buildkittests are sometimes flaky due to the fact that we aretrying to create 2 images in parallel. When we try to do this
buildkitwill try to create a builder, if it doesn't exist, in parallel which
causes a failure.
This commit ensures that the builder is created before we try to run the
parallel test to prevent the above-described issue
Closes #69