-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example for overlaying on an Ingress Object. #572
Conversation
This ReadMe gives the background for why we overlay with ytt and the cmdline to do so.
The ytt config.yaml file backing the Falco Helm chart
The ytt schema.yaml file backing the falco chart
The actual overlaying of the apiVersion and the therefore required paths and backend overlays.
The CLA has been signed |
@larssb Was there some kind of problem with the CLA process? Let us know if you'd like any assistance. |
@pivotaljohn I've tried again. I'm trying to avoid giving up my address. For certain reasons. Thanks |
Gotcha. Let's see how this goes... |
Not seeing any update from CLAbot... any word on your end, @larssb? |
Haven't heard anything from the robot, since the 8th of Jan. Acknowledging that the CLA was signed. |
@larssb, VMware has approved your signed contributor license agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @larssb ! Thank you for helping improve documentation by submitting this example.
From my understanding this example shows:
- Maintaining data values in ytt using the ytt data values schema type-checking features
- Using those values as input to a helm chart
- The helm chart has some compatibility issues with the kubernetes environment, so there is a postrenderer to patch those specific problems using ytt
The goals of examples in this repo is to show real life scenarios that users may have, and present them as recommended ytt code.
This example definitely falls into this category! It shows some great ytt usage. I am sure this use case would be interesting to others. I left some feedback to simplify the amount of context needed from the falco charts so that it can understood by a wider audience.
Hey @larssb, I'm just bumping this PR. Thanks for the effort you've put into this! Let us know if there is anything we can do to help this land. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added changes and some comments. I hope that does it.
Thank you for the patience.
Appreciate your reciprocal patience, @larssb ! Finally had a chance to review and this looks great. 🙏🏻 |
v1beta1 to v1 of the networking API and the consequences that have.
I've tried providing to the point docs for the example. Let me know if more is needed.