Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the Initial scaffolding for the infrastructure provider #6

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Add the Initial scaffolding for the infrastructure provider #6

merged 1 commit into from
Jan 27, 2021

Conversation

fabriziopandini
Copy link
Member

This PR adds the initial bare-bones scaffolding for the infrastructure provider.

At high level this is similar to

kubebuilder init --domain infrastructure.cluster.x-k8s.io
kubebuilder create api --group infrastructure --version v1alpha3 --kind BYOMachine
kubebuilder create api --group infrastructure --version v1alpha3 --kind BYOMachineTemplate

Plus applying some CAPI specific customization

Fixes #5

@fabriziopandini fabriziopandini mentioned this pull request Jan 26, 2021
Closed
jpeach
jpeach reviewed Jan 26, 2021
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
api/v1alpha3/byomachine_types.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
hack/tools/go.mod Outdated Show resolved Hide resolved
@fabriziopandini
Copy link
Member Author

@jpeach thanks for the review
All the comment should be addressed

@fabriziopandini
Copy link
Member Author

renamed byonmachine_controller.go --> byomachine_controller.go for consistency

@fabriziopandini fabriziopandini merged commit 2351d0a into vmware-tanzu:main Jan 27, 2021
@fabriziopandini fabriziopandini deleted the initial-scaffolding branch January 27, 2021 11:51
jamiemonserrate pushed a commit that referenced this pull request Oct 20, 2021
@fabriziopandini
Merge pull request #6 from fabriziopandini/initial-scaffolding
53da876 
Add the Initial scaffolding for the infrastructure provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeach jpeach jpeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initial scaffolding for the infrastructure provider
2 participants
@fabriziopandini @jpeach