This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Deprecate image settings in AKODeploymentConfig #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
owner/packages
jpmcb
changed the title
|
Hi @nicolehanjing - thanks for this PR; I've converted it to a draft PR since it's still a work in progress. Please feel free to set it to "Ready for review" when it's ready! Thanks much!! |
gotcha, will update my changes |
nicolehanjing
force-pushed
the
topic/nicoleh/deprecate-imageinfo
branch
from
0083f31
to
3c06231
Compare
nicolehanjing
force-pushed
the
topic/nicoleh/deprecate-imageinfo
branch
from
3c06231
to
e9f87d7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Deprecate image settings in AKODeploymentConfig.
This PR removes image settings in akoo 1.4.0 and 1.5.0.
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #
Describe testing done for PR
Special notes for your reviewer