This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Removed unneded namespace from packages and template. #2306 #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
owner/packages
sunjayBhatia
approved these changes
Oct 21, 2021
|
This PR will need a new package repository to be published as well. I can handle that. |
nrb
approved these changes
Oct 21, 2021
jpmcb
approved these changes
Oct 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Removes unnecesary namespace declaration from some packages (contour, velero and local-path-storage) as well from the templates so that any new package bootstrapped does not include the reference.
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #2306
Describe testing done for PR
make build-tce-cli-plugins ENVS=darwin-amd64
k apply -f addons/packages/contour/1.18.2/package.yaml -n tanzu-package-repo-global
...
Special notes for your reviewer
NONE
Signed-off-by: Jorge Morales Pou jomorales@vmware.com