This repository has been archived by the owner on Jun 28, 2023. It is now read-only.
Create OpenAPIV3 schema for metrics-server package and generate package with the schema #2758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blc1996
changed the title
github-actions
bot
added
the
owner/docs
shivaani0505
reviewed
Jan 4, 2022
shivaani0505
reviewed
Jan 4, 2022
shivaani0505
reviewed
Jan 4, 2022
|
@blc1996 you need to create a separate issue in tce and fix "Which issue(s) this PR fixes" section, Issue mentioned there is for Secret Gen controller |
blc1996
force-pushed
the
luchengb/openapi-metrics-server
branch
from
d25b4cb
to
179ad00
Compare
blc1996
changed the title
Signed-off-by: Lucheng Bao <luchengb@vmware.com>
blc1996
force-pushed
the
luchengb/openapi-metrics-server
branch
from
179ad00
to
b6f28a8
Compare
|
Hi @ggpaue , could you take a look at this MR? |
|
@blc1996 the change looks good to me and I will approve it, can you add what ytt commands you used for testing in the description before merge? thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lucheng Bao luchengb@vmware.com
What this PR does / why we need it
Create OpenAPIV3 schema for metrics-server package and generate package with the schema
Details for the Release Notes (PLEASE PROVIDE)
Which issue(s) this PR fixes
Fixes: #2803
Describe testing done for PR
Tested with ytt commands
$ make generate-openapischema-package PACKAGE=metrics-server VERSION=0.5.1
Special notes for your reviewer
YTT version needs to be bumped to latest (0.38.0)