Skip to content
This repository has been archived by the owner on Jun 28, 2023. It is now read-only.

Create OpenAPIV3 schema for antrea versions ( 1.2.3, 0.13.3, 0.11.3 ) and generate package with the schema #2843

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Create OpenAPIV3 schema for antrea versions ( 1.2.3, 0.13.3, 0.11.3 ) and generate package with the schema #2843

merged 1 commit into from
Jan 14, 2022

Conversation

shivaani0505
Copy link
Contributor

@shivaani0505 shivaani0505 commented Jan 13, 2022 •
edited
Loading

What this PR does / why we need it

  • Create OpenAPIV3 schema for antrea versions ( 1.2.3, 0.13.3, 0.11.3 ) and generate package with the schema

Details for the Release Notes (PLEASE PROVIDE)

Create OpenAPIV3 schema for antrea package and generate package with the schema

Which issue(s) this PR fixes

Fixes: #2842

Describe testing done for PR

Tested with following ytt commands locally:
below can be substituted with each item from the list: ( 1.2.3, 0.13.3, 0.11.3 )

  • make generate-openapischema-package PACKAGE=antrea VERSION=1.2.3
  • make push-package PACKAGE=antrea VERSION=1.2.3 TAG=1.2.3

Special notes for your reviewer

ytt version => 0.38.0
kapp version => 0.37.0
yq version => 4.11.1

Also, I would be adding github workflow in the same PR which I am currently working on

@shivaani0505
Create OpenAPIV3 schema for antrea versions ( 1.2.3, 0.13.3,0.11.3 ) …
65fe248 
…and generate package with the schema

Signed-off-by: Shivaani Gupta <gshivaani@vmware.com>
@shivaani0505 shivaani0505 requested a review from a team as a code owner January 13, 2022 18:18
@github-actions github-actions bot added owner/docs Work executed by VMware documentation team owner/packages Work executed by a package's maintainer labels Jan 13, 2022
blc1996
blc1996 approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@blc1996 blc1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blc1996
Copy link
Contributor

blc1996 commented Jan 14, 2022

Hi @vmware-tanzu/pkg-antrea-owners , could someone also review the added openAPI schema for Antrea? Thanks!

@knabben
Copy link
Member

knabben commented Jan 14, 2022

LGTM

@shivaani0505
Copy link
Contributor Author

LGTM

Could you provide your approval @knabben

@seemiller seemiller merged commit 4510caa into main Jan 14, 2022
@stmcginnis stmcginnis deleted the openapi-antrea-tce branch January 20, 2022 22:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@knabben knabben knabben approved these changes

@blc1996 blc1996 blc1996 approved these changes

@seemiller seemiller Awaiting requested review from seemiller

@jayunit100 jayunit100 Awaiting requested review from jayunit100

Assignees
No one assigned
Labels
cla-not-required owner/docs Work executed by VMware documentation team owner/packages Work executed by a package's maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create OpenAPIV3 schema for antrea versions(1.2.3, 0.13.3, 0.11.3) in TCE
5 participants
@shivaani0505 @blc1996 @knabben @seemiller @vmwclabot